Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests running slow. #17

Closed
tammersaleh opened this issue Nov 17, 2014 · 5 comments
Closed

Tests running slow. #17

tammersaleh opened this issue Nov 17, 2014 · 5 comments

Comments

@tammersaleh
Copy link

Tests on my machine are running super slow:

$ rake
/Users/tsaleh/.rbenv/versions/2.1.2/bin/ruby -I"lib:lib:test" -I"/Users/tsaleh/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/rake-10.3.2/lib" "/Users/tsaleh/.rbenv/versions/2.1.2/lib/ruby/gems/2.1.0/gems/rake-10.3.2/lib/rake/rake_test_loader.rb" "test/client_test.rb" "test/project_test.rb" "test/story_test.rb"
Run options: --seed 61100

# Running:

.................

Finished in 54.092713s, 0.3143 runs/s, 1.1832 assertions/s.

17 runs, 64 assertions, 0 failures, 0 errors, 0 skips`

Feels to me like VCR is hitting the network each time, but I can't imagine why. I'm not super familiar with VCR... Any tips on debugging this?

@tammersaleh
Copy link
Author

I think VCR is a red herring. Setting record: :none on all calls to use_cassette didn't change the test run time. In fact, setting that seemed to slow things down? Am I the only one experiencing this?

@tammersaleh tammersaleh changed the title Tests running slow. VCR misconfiguration? Tests running slow. Nov 17, 2014
@forest
Copy link
Contributor

forest commented Nov 17, 2014

I'll see if I can reproduce.

On Mon Nov 17 2014 at 7:40:15 AM Tammer Saleh [email protected]
wrote:

I think VCR is a red herring. Setting record: :none on all calls to
use_cassette didn't change the test run time. In fact, setting that
seemed to slow things down? Am I the only one experiencing this?


Reply to this email directly or view it on GitHub
#17 (comment)
.

@forest
Copy link
Contributor

forest commented Nov 17, 2014

I got a little bit better run time.

Finished in 26.176623s, 0.6494 runs/s, 2.4831 assertions/s.

But then I unplugged from the network and all the tests failed. So there is something wrong with VCR using the existing cassettes. I'll look into it more.

@forest forest closed this as completed in ac9fe27 Nov 17, 2014
@forest
Copy link
Contributor

forest commented Nov 17, 2014

This is better.

Finished in 0.444822s, 38.2175 runs/s, 146.1259 assertions/s.

@tammersaleh
Copy link
Author

Runs lightening fast on my machine as well! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants