Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling for token auth #54

Open
luisjunco opened this issue Jan 27, 2023 · 0 comments
Open

Improve error handling for token auth #54

luisjunco opened this issue Jan 27, 2023 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@luisjunco
Copy link
Contributor

luisjunco commented Jan 27, 2023

Issue

For token based auth, when a token is not valid or not provided, the api returns a 500 error.

Sending a 401 would be more appropriate plus, can help students to identify easier why their requests failed.

image

Solution

In error-handling\index.js, we can improve error handling adding the following:

//Unauthorized
if (err.name === "UnauthorizedError") {
  res.status(401).json({ message: `Unauthorized: ${err.inner?.message}` });
}

image

@ross-u ross-u added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants