Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unable to build on nightly-2019-08-02 #148

Closed
miller-time opened this issue Aug 2, 2019 · 2 comments · Fixed by iron/iron#614
Closed

unable to build on nightly-2019-08-02 #148

miller-time opened this issue Aug 2, 2019 · 2 comments · Fixed by iron/iron#614

Comments

@miller-time
Copy link

miller-time commented Aug 2, 2019 •
edited
Loading

unstabilizing #[bench] (rust-lang/rust#62507) has broken the route-recognizer crate's ability to build on nightly:

$ cargo +nigtly build
...
error[E0658]: use of unstable library feature 'test': `bench` is a part of custom test frameworks which are unstable

#[bench]
  ^^^^^
 help: add `#![feature(test)]` to the crate attributes to enable

I have a PR open... http-rs/route-recognizer#25

To clarify:

  • nightly-2019-07-31 - ✔️
    (nightly-2019-07-31-x86_64-unknown-linux-gnu installed - rustc 1.38.0-nightly (dddb7fca0 2019-07-30))
  • nightly-2019-08-01 - ✔️
    (nightly-2019-08-01-x86_64-unknown-linux-gnu installed - rustc 1.38.0-nightly (8a58268b5 2019-07-31))
  • nightly-2019-08-02 - ❌
    (nightly-2019-08-02-x86_64-unknown-linux-gnu installed - rustc 1.38.0-nightly (435236b88 2019-08-01))
@miller-time miller-time changed the title unable to build on nightly (2019-08-01) unable to build on nightly-2019-08-02 Aug 2, 2019
@miller-time
Copy link
Author

  • nightly-2019-08-03 - ❌
    (nightly-2019-08-03-x86_64-unknown-linux-gnu installed - rustc 1.38.0-nightly (b0e40bfba 2019-08-02))
  • nightly-2019-08-04 - ❌
    (nightly-2019-08-04-x86_64-unknown-linux-gnu installed - rustc 1.38.0-nightly (6e0d27d93 2019-08-03))

@miller-time
Copy link
Author

  • nightly-2019-08-05 - ❌
    (nightly-2019-08-05-x86_64-unknown-linux-gnu installed - rustc 1.38.0-nightly (d3f8a0b5d 2019-08-04))
  • nightly-2019-08-06 - ❌
    (nightly-2019-08-06-x86_64-unknown-linux-gnu installed - rustc 1.38.0-nightly (c4715198b 2019-08-05))

miller-time added a commit to miller-time/router that referenced this issue Aug 9, 2019
@miller-time
fix nightly build (fixes iron#148)
8b68733 
I guess route-recognizer is no longer maintained? My PR:
http-rs/route-recognizer#25
Comment from Alex Crichton:
http-rs/route-recognizer#26 (comment)
miller-time added a commit to miller-time/router that referenced this issue Aug 9, 2019
@miller-time
fix nightly build (fixes iron#148)
b4e4eb7 
I guess route-recognizer is no longer maintained? My PR:
http-rs/route-recognizer#25
Comment from Alex Crichton:
http-rs/route-recognizer#26 (comment)
@miller-time miller-time mentioned this issue Aug 9, 2019
Closed
miller-time added a commit to miller-time/router that referenced this issue Aug 9, 2019
@miller-time
fix nightly build
4e735ff 
closes iron#148

- use patch for route-recognizer
- add `dyn` to trait objects

I guess route-recognizer is no longer maintained? My PR:
http-rs/route-recognizer#25
Comment from Alex Crichton:
http-rs/route-recognizer#26 (comment)
miller-time added a commit to miller-time/router that referenced this issue Aug 13, 2019
@miller-time
fix nightly build
226a13a 
closes iron#148

- use patch for route-recognizer
- add `dyn` to trait objects

I guess route-recognizer is no longer maintained? My PR:
http-rs/route-recognizer#25
Comment from Alex Crichton:
http-rs/route-recognizer#26 (comment)
miller-time added a commit to miller-time/iron that referenced this issue Aug 13, 2019
@miller-time
fix nightly build of router crate
dd80071 
closes iron/router#148

- update route-recognizer
- add `dyn` to trait objects
@miller-time miller-time mentioned this issue Aug 13, 2019
Merged
miller-time added a commit to miller-time/iron that referenced this issue Aug 13, 2019
@miller-time
fix nightly build of router crate
bb234cf 
closes iron/router#148

- update route-recognizer (implicitly)
- add `dyn` to trait objects
miller-time added a commit to miller-time/iron that referenced this issue Aug 13, 2019
@miller-time
fix nightly build of router crate
39289be 
closes iron/router#148

- update route-recognizer (implicitly)
- add `dyn` to trait objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix nightly build of router crate miller-time/iron
fix nightly build miller-time/router
1 participant
@miller-time