Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot currently write correct metadata from NRL v1 or v2: customizing an NRL response #49

Open
rcasey-earthscope opened this issue Mar 12, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@rcasey-earthscope
Copy link
Collaborator

@metempleton :
I could not currently write correct metadata (with either NRL version), due either to bugs or inappropriate logic if you customize an NRL response (wrong number of poles/zeros and sensitivity issues).

I just finished testing Yasmine to update IM metadata. Outside of documented bugs, it actually
worked - until I customized my responses and had no way to recalculate total sensitivity.
So a user would need to export the XML, run evalresp on it to find the new value, and make
edits. Also, Yasmine validate response amplitudes, and if stage gain frequencies vary, neither
does the stationXML validator. When you put all of this together, it seems like a recipe for a lot
of bad response sensitivities.
Can Yasmine include a sensitivity calculator that handles frequency correctly (rather than just
multiplying stage gains)?

@rcasey-earthscope
Copy link
Collaborator Author

Provided the code can create viable sensitivity values from an NRL instrumentation merge, this would suggest that the evalresp-like code exists, but is not wired to properly trigger when hand edits are done. I thought all of this code was built in to ObsPy, so there might be something in the Yasmine wiring that needs to be added.

@rcasey-earthscope rcasey-earthscope added the bug Something isn't working label Mar 12, 2024
@metempleton
Copy link
Collaborator

metempleton commented Mar 13, 2024

In addition to not being able to recalculate total sensitivity, the problem of not being able to write correct metadata for customized responses is also due to bugs #37 and #40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants