Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update output messages for validator rules. #75

Closed
timronan opened this issue Mar 8, 2019 · 2 comments
Closed

Update output messages for validator rules. #75

timronan opened this issue Mar 8, 2019 · 2 comments

Comments

@timronan
Copy link
Collaborator

timronan commented Mar 8, 2019

Change output messaging for column 1 of error/warning 402 from "null" to /path/to/file.

Remove commas from output messages from error 201 and 302.

@timronan
Copy link
Collaborator Author

timronan commented Apr 4, 2019

Change output messaging for column 1 of error/warning 402 from "null" to /path/to/file.
Error/warning 402 utilizes the NestedMessage class at stationxml-validator.edu.iris.dmc.station.rules which currently does not have access to the path of the source file.

It seems like the source path could be provided to the NestedMessage class by adding a setSource method. The NestedMessage.setSource method could utilize the Message.getSource and Message.setSource methods.

	@Override
	public void setSource(String source) {
		super.setSource(source);
		for(Message message:nestedMessages){
			source = message.getSource();
			message.setSource(source);
		}
	}

This code block does not work as described above and needs to be modified.

Remove commas from output messages from error 201 and 302.
This has been addressed.

@timronan
Copy link
Collaborator Author

The output messaging has been improved through many different commits. Nested messaging has been included for all relevant rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant