Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safebrowsing downloads from Google #10

Closed
fancycode opened this issue May 29, 2015 · 8 comments
Closed

Safebrowsing downloads from Google #10

fancycode opened this issue May 29, 2015 · 8 comments
Assignees

Comments

@fancycode
Copy link

Safebrowsing data is still downloaded from Google:

Attempt at loading traced URL: trk:165:https://safebrowsing.google.com/safebrowsing/downloads?client=chromium&appver=43.1&pver=3.0&key=dummytoken

Didn't we already decide to point this to our own server?

@jengelh
Copy link
Member

jengelh commented May 29, 2015

Could be some new annoyances introduced by Google recently.

@fancycode
Copy link
Author

@jengelh
Copy link
Member

jengelh commented Jun 19, 2015

The patch does not help if the data is not actually present on cache.iridiumbrowser.de - and since it is not downloadable directly with curl (yields HTTP 400), the patch alone is not enough.

@fancycode
Copy link
Author

Wasn't the original plan to return a 307 for that URL so the actual data is still fetched from Google?

@theurere
Copy link

When enabling the Privacy preference "Enable phishing and malware protection" there are now requests for safebrowsing-cache.google.com and safebrowsing.google.com at tests 4 and 6

@fancycode
Copy link
Author

@longsleep
Copy link
Contributor

307 approach does not work, closing for now as we decided to load from Google and let the user opt out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants