From f03554cc01718ddb956380086c504ac4f3d355c6 Mon Sep 17 00:00:00 2001 From: irfan sharif Date: Tue, 4 Apr 2023 11:03:07 -0400 Subject: [PATCH] rpc: remove debug logging This was added recently, in #94778, and contributes to log spam of the following sort: I230404 15:00:33.826337 2400 rpc/context.go:2249 [T1,n1,rnode=2,raddr=127.0.0.1:55941,class=default,rpc] 268 connection heartbeat loop ended with err: I230404 15:00:33.826338 3986 rpc/context.go:2249 [T1,n2,rnode=3,raddr=127.0.0.1:55955,class=system,rpc] 269 connection heartbeat loop ended with err: I230404 15:00:33.826367 3455 rpc/context.go:2249 [T1,n2,rnode=3,raddr=127.0.0.1:55955,class=default,rpc] 270 connection heartbeat loop ended with err: I230404 15:00:33.826394 3354 rpc/context.go:2249 [T1,n2,rnode=2,raddr=127.0.0.1:55941,class=default,rpc] 271 connection heartbeat loop ended with err: Release note: None --- pkg/rpc/context.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/rpc/context.go b/pkg/rpc/context.go index 097cb297c42e..72cea1abf667 100644 --- a/pkg/rpc/context.go +++ b/pkg/rpc/context.go @@ -2298,8 +2298,7 @@ func (rpcCtx *Context) grpcDialNodeInternal( // Run the heartbeat; this will block until the connection breaks for // whatever reason. We don't actually have to do anything with the error, // so we ignore it. - err := rpcCtx.runHeartbeat(ctx, conn, target) - log.Infof(ctx, "connection heartbeat loop ended with err: %v", err) + _ = rpcCtx.runHeartbeat(ctx, conn, target) maybeFatal(ctx, rpcCtx.m.Remove(k, conn)) // Context gets canceled on server shutdown, and if that's likely why