From d75e8bc4292d4ed6390995444405428b2d0dcac3 Mon Sep 17 00:00:00 2001 From: irfan sharif Date: Mon, 12 Jun 2023 13:58:49 -0400 Subject: [PATCH] kvflowcontrol: enable by default Enable kvadmission.flow_control.enabled by default. We didn't observe noticeable performance regressions while it was disabled (single weekly run, three nightly runs). There was some minimal fallout that was since fixed (#104699). We expect performance regressions now that this commit enables it by default, and expect more fallout. We'll handle these as part of #104154. Release note: None --- pkg/kv/kvserver/kvflowcontrol/kvflowcontrol.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/kv/kvserver/kvflowcontrol/kvflowcontrol.go b/pkg/kv/kvserver/kvflowcontrol/kvflowcontrol.go index 875636b47546..7e8c5d9fdb32 100644 --- a/pkg/kv/kvserver/kvflowcontrol/kvflowcontrol.go +++ b/pkg/kv/kvserver/kvflowcontrol/kvflowcontrol.go @@ -30,7 +30,7 @@ var Enabled = settings.RegisterBoolSetting( settings.SystemOnly, "kvadmission.flow_control.enabled", "determines whether we use flow control for replication traffic in KV", - false, + true, ) // Mode determines the 'mode' of flow control we use for replication traffic in