forked from cockroachdb/cockroach
-
Notifications
You must be signed in to change notification settings - Fork 0
/
raft_transport.go
1172 lines (1069 loc) · 42.4 KB
/
raft_transport.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
// Copyright 2015 The Cockroach Authors.
//
// Use of this software is governed by the Business Source License
// included in the file licenses/BSL.txt.
//
// As of the Change Date specified in that file, in accordance with
// the Business Source License, use of this software will be governed
// by the Apache License, Version 2.0, included in the file
// licenses/APL.txt.
package kvserver
import (
"context"
"net"
"runtime/pprof"
"sync/atomic"
"time"
"unsafe"
"github.com/cockroachdb/cockroach/pkg/base"
"github.com/cockroachdb/cockroach/pkg/kv/kvpb"
"github.com/cockroachdb/cockroach/pkg/kv/kvserver/allocator/storepool"
"github.com/cockroachdb/cockroach/pkg/kv/kvserver/kvadmission"
"github.com/cockroachdb/cockroach/pkg/kv/kvserver/kvflowcontrol"
"github.com/cockroachdb/cockroach/pkg/kv/kvserver/kvflowcontrol/kvflowcontrolpb"
"github.com/cockroachdb/cockroach/pkg/kv/kvserver/kvflowcontrol/kvflowdispatch"
"github.com/cockroachdb/cockroach/pkg/kv/kvserver/kvserverpb"
"github.com/cockroachdb/cockroach/pkg/roachpb"
"github.com/cockroachdb/cockroach/pkg/rpc"
"github.com/cockroachdb/cockroach/pkg/rpc/nodedialer"
"github.com/cockroachdb/cockroach/pkg/settings"
"github.com/cockroachdb/cockroach/pkg/settings/cluster"
"github.com/cockroachdb/cockroach/pkg/storage"
"github.com/cockroachdb/cockroach/pkg/util/admission/admissionpb"
"github.com/cockroachdb/cockroach/pkg/util/log"
"github.com/cockroachdb/cockroach/pkg/util/stop"
"github.com/cockroachdb/cockroach/pkg/util/syncutil"
"github.com/cockroachdb/cockroach/pkg/util/timeutil"
"github.com/cockroachdb/cockroach/pkg/util/tracing"
"github.com/cockroachdb/errors"
"go.etcd.io/raft/v3/raftpb"
"google.golang.org/grpc"
)
const (
// Outgoing messages are queued per-node on a channel of this size.
//
// This buffer was sized many moons ago and is very large. If the
// buffer fills up, we drop raft messages, so we'd be in trouble.
// But as is, the buffer can hold to a lot of memory, especially
// during RESTORE/IMPORT where we're routinely sending out SSTs,
// which weigh in at a few mbs each; an individual raft instance
// will limit how many it has in-flight per-follower, but groups
// don't compete among each other for budget.
raftSendBufferSize = 10000
// When no message has been queued for this duration, the corresponding
// instance of processQueue will shut down.
//
// TODO(tamird): make culling of outbound streams more evented, so that we
// need not rely on this timeout to shut things down.
raftIdleTimeout = time.Minute
)
// targetRaftOutgoingBatchSize wraps "kv.raft.command.target_batch_size".
var targetRaftOutgoingBatchSize = settings.RegisterByteSizeSetting(
settings.SystemOnly,
"kv.raft.command.target_batch_size",
"size of a batch of raft commands after which it will be sent without further batching",
64<<20, // 64 MB
settings.PositiveInt,
)
// RaftMessageResponseStream is the subset of the
// MultiRaft_RaftMessageServer interface that is needed for sending responses.
type RaftMessageResponseStream interface {
Send(*kvserverpb.RaftMessageResponse) error
}
// lockedRaftMessageResponseStream is an implementation of
// RaftMessageResponseStream which provides support for concurrent calls to
// Send. Note that the default implementation of grpc.Stream for server
// responses (grpc.serverStream) is not safe for concurrent calls to Send.
type lockedRaftMessageResponseStream struct {
wrapped MultiRaft_RaftMessageBatchServer
sendMu syncutil.Mutex
}
func (s *lockedRaftMessageResponseStream) Send(resp *kvserverpb.RaftMessageResponse) error {
s.sendMu.Lock()
defer s.sendMu.Unlock()
return s.wrapped.Send(resp)
}
func (s *lockedRaftMessageResponseStream) Recv() (*kvserverpb.RaftMessageRequestBatch, error) {
// No need for lock. gRPC.Stream.RecvMsg is safe for concurrent use.
return s.wrapped.Recv()
}
// SnapshotResponseStream is the subset of the
// MultiRaft_RaftSnapshotServer interface that is needed for sending responses.
type SnapshotResponseStream interface {
Send(*kvserverpb.SnapshotResponse) error
Recv() (*kvserverpb.SnapshotRequest, error)
}
// RaftMessageHandler is the interface that must be implemented by
// arguments to RaftTransport.Listen.
type RaftMessageHandler interface {
// HandleRaftRequest is called for each incoming Raft message. The request is
// always processed asynchronously and the response is sent over respStream.
// If an error is encountered during asynchronous processing, it will be
// streamed back to the sender of the message as a RaftMessageResponse.
HandleRaftRequest(ctx context.Context, req *kvserverpb.RaftMessageRequest,
respStream RaftMessageResponseStream) *kvpb.Error
// HandleRaftResponse is called for each raft response. Note that
// not all messages receive a response. An error is returned if and only if
// the underlying Raft connection should be closed.
HandleRaftResponse(context.Context, *kvserverpb.RaftMessageResponse) error
// HandleSnapshot is called for each new incoming snapshot stream, after
// parsing the initial SnapshotRequest_Header on the stream.
HandleSnapshot(
ctx context.Context,
header *kvserverpb.SnapshotRequest_Header,
respStream SnapshotResponseStream,
) error
// HandleDelegatedSnapshot is called for each incoming delegated snapshot
// request.
HandleDelegatedSnapshot(
ctx context.Context,
req *kvserverpb.DelegateSendSnapshotRequest,
) *kvserverpb.DelegateSnapshotResponse
}
// RaftTransport handles the rpc messages for raft.
//
// The raft transport is asynchronous with respect to the caller, and
// internally multiplexes outbound messages. Internally, each message is
// queued on a per-destination queue before being asynchronously delivered.
//
// Callers are required to construct a RaftSender before being able to
// dispatch messages, and must provide an error handler which will be invoked
// asynchronously in the event that the recipient of any message closes its
// inbound RPC stream. This callback is asynchronous with respect to the
// outbound message which caused the remote to hang up; all that is known is
// which remote hung up.
type RaftTransport struct {
log.AmbientContext
st *cluster.Settings
tracer *tracing.Tracer
stopper *stop.Stopper
metrics *RaftTransportMetrics
// Queues maintains a map[roachpb.NodeID]*raftSendQueue on a per rpc-class
// level. When new raftSendQueues are instantiated, or old ones deleted, we
// also maintain kvflowControl.mu.connectedTracker. So writing to this field
// is done while holding kvflowControl.mu.
queues [rpc.NumConnectionClasses]syncutil.IntMap
dialer *nodedialer.Dialer
handlers syncutil.IntMap // map[roachpb.StoreID]*RaftMessageHandler
kvflowControl struct {
// Everything nested under this struct is used to return flow tokens
// from the receiver (where work was admitted) up to the sender (where
// work originated and tokens were deducted). There are few parts to the
// protocol, and can be experimented with using TestFlowControlRaftTransport
// and various TestFlowControl* tests in this package. We briefly sketch
// how the various pieces fit below, repeating some of what is described
// in kvflowcontrol/doc.go (which details about how/why we integrate
// with the RaftTransport so intimately).
//
// Background: Each CRDB node acts as both the "server" and the "client"
// of bidirectional RaftTransport streams. That is, raft messages from
// n1->n2 are sent from the client code on n1 to server code on n2.
// Responses to those raft messages are sent from the client code on n2
// to server code in n1.
//
// - When flow tokens are deducted where the MsgApps originate, and
// after they're admitted below-raft, the remote nodes send back
// kvflowcontrolpb.AdmittedRaftLogEntries through the RaftMessageBatch
// stream. This happens on the client side, and we read from
// dispatchReader and either attach the protos to already outbound
// messages, or fire off one-off messages periodically if there's
// little raft activity but still tokens to be returned.
//
// - On the server side, we intercept every message and look for these
// protos, and inform the storesForFlowControl integration interface
// of this fact.
//
// - The server side maintains the set of client-side stores it's
// currently connected to, from the POV of these server side streams.
// Since tokens are returned to the server along these streams, when
// they disconnect, it's possible for us to be leaking tokens in
// transit. So it uses information about the set of client-side stores
// it's no longer connected to, to simply free up all held tokens. See
// uses of connectionTracker below and how the storesForFlowControl
// interface is informed about stores we're no longer connected to.
//
// - There's some complexity in how this set of connected stores is
// tracked. For one it's a "connected" set, not a "disconnected"
// one. It's hard to do the latter. Ignoring memory maintenance
// issues that come from nodes that are no longer part of the
// cluster, we have multiple RPC classes from the client side and
// clients are also free to establish/disconnect many streams
// concurrently without synchronization on their end. The server is
// not guaranteed to learn about these streams connecting or
// disconnecting in any particular order, so it's difficult to track
// directly by looking at connection/disconnection events alone
// whether we're connected somehow to a given client. Some form of
// heartbeat scheme comes to mind, which fits more naturally with
// tracking the set of "connected" stores. We can still react to
// streams disconnecting by clearing the relevant stores from the
// tracked set, relying on a subsequent heartbeat (from, say, a
// different stream/RPC class) to re-track that client+its store as
// connected.
//
// - How does the server learn about what stores are present on each
// client? When establishing the stream, the client simply sends this
// information over. If the client learns of newly added stores
// (possible during early startup), it sends it again. See uses of
// localStoreIDs and setAdditionalStoreIDs below.
//
// - Idle streams are periodically culled from the client side. It's
// possible that we cull a stream without having delivered all flow
// tokens to the sender (for example, if below-raft admission happens
// after the stream is culled). The server side detected these
// disconnected streams and releases tokens, but on the client side we
// don't want to accumulate to-be-delivered flow tokens unboundedly.
// So we track the set of servers we're connected to, across all RPC
// classes, and periodically just clear our outbox if there are
// dispatches bound for nodes we're simply not connected to, across
// all RPC classes. See uses of connectedNodes below.
mu struct {
syncutil.RWMutex
localStoreIDs []roachpb.StoreID // sent to servers to track client-side stores
connectionTracker *connectionTrackerForFlowControl
}
setAdditionalStoreIDs atomic.Bool
dispatchReader kvflowcontrol.DispatchReader
handles kvflowcontrol.Handles
disconnectListener RaftTransportDisconnectListener
}
knobs *RaftTransportTestingKnobs
}
// raftSendQueue is a queue of outgoing RaftMessageRequest messages.
type raftSendQueue struct {
reqs chan *kvserverpb.RaftMessageRequest
// The specific node this queue is sending RaftMessageRequests to.
nodeID roachpb.NodeID
// The number of bytes in flight. Must be updated *atomically* on sending and
// receiving from the reqs channel.
bytes atomic.Int64
}
// NewDummyRaftTransport returns a dummy raft transport for use in tests which
// need a non-nil raft transport that need not function.
func NewDummyRaftTransport(st *cluster.Settings, tracer *tracing.Tracer) *RaftTransport {
resolver := func(roachpb.NodeID) (net.Addr, error) {
return nil, errors.New("dummy resolver")
}
return NewRaftTransport(log.MakeTestingAmbientContext(tracer), st, tracer,
nodedialer.New(nil, resolver), nil, nil,
kvflowdispatch.NewDummyDispatch(), NoopStoresFlowControlIntegration{},
NoopRaftTransportDisconnectListener{},
nil,
)
}
// NewRaftTransport creates a new RaftTransport.
func NewRaftTransport(
ambient log.AmbientContext,
st *cluster.Settings,
tracer *tracing.Tracer,
dialer *nodedialer.Dialer,
grpcServer *grpc.Server,
stopper *stop.Stopper,
kvflowTokenDispatch kvflowcontrol.DispatchReader,
kvflowHandles kvflowcontrol.Handles,
disconnectListener RaftTransportDisconnectListener,
knobs *RaftTransportTestingKnobs,
) *RaftTransport {
if knobs == nil {
knobs = &RaftTransportTestingKnobs{}
}
t := &RaftTransport{
AmbientContext: ambient,
st: st,
tracer: tracer,
stopper: stopper,
dialer: dialer,
knobs: knobs,
}
t.kvflowControl.dispatchReader = kvflowTokenDispatch
t.kvflowControl.handles = kvflowHandles
t.kvflowControl.disconnectListener = disconnectListener
t.kvflowControl.mu.connectionTracker = newConnectionTrackerForFlowControl()
t.initMetrics()
if grpcServer != nil {
RegisterMultiRaftServer(grpcServer, t)
}
return t
}
// Start various internal goroutines needed for the RaftTransport's internal
// functioning.
func (t *RaftTransport) Start(ctx context.Context) error {
if err := t.startDroppingFlowTokensForDisconnectedNodes(ctx); err != nil {
return errors.Wrapf(err, "failed to run flow token dispatch loop")
}
return nil
}
// SetInitialStoreIDs informs the RaftTransport of the initial set of store
// IDs the local node starts off with. If it's a restarting node, restarted with
// no additional stores, this is just all the local store IDs. For nodes newly
// added to the cluster, it's just the first initialized store. If there are
// additional stores post-restart, or stores other than the first for a newly
// added node, they're provided using (*RaftTransport).SetAdditionalStoreIDs.
func (t *RaftTransport) SetInitialStoreIDs(storeIDs []roachpb.StoreID) {
t.kvflowControl.mu.Lock()
defer t.kvflowControl.mu.Unlock()
t.kvflowControl.mu.localStoreIDs = storeIDs
}
// SetAdditionalStoreIDs informs the RaftTransport of any additional stores the
// local node starts off with. See commentary on SetInitialStoreIDs for more
// details.
func (t *RaftTransport) SetAdditionalStoreIDs(storeIDs []roachpb.StoreID) {
if len(storeIDs) == 0 {
return // nothing to do
}
t.kvflowControl.mu.Lock()
defer t.kvflowControl.mu.Unlock()
t.kvflowControl.mu.localStoreIDs = append(t.kvflowControl.mu.localStoreIDs, storeIDs...)
t.kvflowControl.setAdditionalStoreIDs.Store(true)
}
// Metrics returns metrics tracking this transport.
func (t *RaftTransport) Metrics() *RaftTransportMetrics {
return t.metrics
}
// visitQueues calls the visit callback on each outgoing messages sub-queue.
func (t *RaftTransport) visitQueues(visit func(*raftSendQueue)) {
for class := range t.queues {
t.queues[class].Range(func(k int64, v unsafe.Pointer) bool {
visit((*raftSendQueue)(v))
return true
})
}
}
// queueMessageCount returns the total number of outgoing messages in the queue.
func (t *RaftTransport) queueMessageCount() int64 {
var count int64
t.visitQueues(func(q *raftSendQueue) { count += int64(len(q.reqs)) })
return count
}
// queueByteSize returns the total bytes size of outgoing messages in the queue.
func (t *RaftTransport) queueByteSize() int64 {
var size int64
t.visitQueues(func(q *raftSendQueue) { size += q.bytes.Load() })
return size
}
func (t *RaftTransport) getHandler(storeID roachpb.StoreID) (RaftMessageHandler, bool) {
if value, ok := t.handlers.Load(int64(storeID)); ok {
return *(*RaftMessageHandler)(value), true
}
return nil, false
}
// handleRaftRequest proxies a request to the listening server interface.
func (t *RaftTransport) handleRaftRequest(
ctx context.Context, req *kvserverpb.RaftMessageRequest, respStream RaftMessageResponseStream,
) *kvpb.Error {
for i := range req.AdmittedRaftLogEntries {
// Process any flow tokens that were returned over the RaftTransport. Do
// this first thing, before these requests enter the receive queues
// which could drop them if full and cause token leaks, or bail after
// processing the raft heartbeats. See I8 from kvflowcontrol/doc.go.
admittedEntries := req.AdmittedRaftLogEntries[i]
handle, found := t.kvflowControl.handles.Lookup(admittedEntries.RangeID)
if found {
handle.ReturnTokensUpto(
ctx,
admissionpb.WorkPriority(admittedEntries.AdmissionPriority),
admittedEntries.UpToRaftLogPosition,
kvflowcontrol.Stream{StoreID: admittedEntries.StoreID},
)
}
if log.V(1) {
log.Infof(ctx, "informed of below-raft %s", admittedEntries)
}
}
if req.ToReplica.StoreID == roachpb.StoreID(0) && len(req.AdmittedRaftLogEntries) > 0 {
// The fallback token dispatch mechanism does not specify a destination
// replica, and as such, there's no handler for it. We don't want to
// return StoreNotFoundErrors in such cases.
return nil
}
handler, ok := t.getHandler(req.ToReplica.StoreID)
if !ok {
log.Warningf(ctx, "unable to accept Raft message from %+v: no handler registered for %+v",
req.FromReplica, req.ToReplica)
return kvpb.NewError(kvpb.NewStoreNotFoundError(req.ToReplica.StoreID))
}
return handler.HandleRaftRequest(ctx, req, respStream)
}
// newRaftMessageResponse constructs a RaftMessageResponse from the
// given request and error.
func newRaftMessageResponse(
req *kvserverpb.RaftMessageRequest, pErr *kvpb.Error,
) *kvserverpb.RaftMessageResponse {
resp := &kvserverpb.RaftMessageResponse{
RangeID: req.RangeID,
// From and To are reversed in the response.
ToReplica: req.FromReplica,
FromReplica: req.ToReplica,
}
if pErr != nil {
resp.Union.SetValue(pErr)
}
return resp
}
// RaftMessageBatch proxies the incoming requests to the listening server interface.
func (t *RaftTransport) RaftMessageBatch(stream MultiRaft_RaftMessageBatchServer) (lastErr error) {
errCh := make(chan error, 1)
// Node stopping error is caught below in the select.
taskCtx, cancel := t.stopper.WithCancelOnQuiesce(stream.Context())
taskCtx = t.AnnotateCtx(taskCtx)
defer cancel()
var storeIDs []roachpb.StoreID
defer func() {
ctx := t.AnnotateCtx(context.Background())
t.kvflowControl.mu.Lock()
t.kvflowControl.mu.connectionTracker.markStoresDisconnected(storeIDs)
t.kvflowControl.mu.Unlock()
t.kvflowControl.disconnectListener.OnRaftTransportDisconnected(ctx, storeIDs...)
if fn := t.knobs.OnServerStreamDisconnected; fn != nil {
fn()
}
}()
if err := t.stopper.RunAsyncTaskEx(
taskCtx,
stop.TaskOpts{
TaskName: "storage.RaftTransport: processing batch",
SpanOpt: stop.ChildSpan,
}, func(ctx context.Context) {
errCh <- func() error {
stream := &lockedRaftMessageResponseStream{wrapped: stream}
for {
batch, err := stream.Recv()
if err != nil {
return err
}
if len(batch.StoreIDs) > 0 {
// Collect the set of store IDs from the client side to
// later free up relevant flow tokens once the gRPC
// stream breaks/disconnects.
storeIDs = batch.StoreIDs
}
t.kvflowControl.mu.Lock()
t.kvflowControl.mu.connectionTracker.markStoresConnected(storeIDs)
t.kvflowControl.mu.Unlock()
if len(batch.Requests) == 0 {
continue
}
for i := range batch.Requests {
req := &batch.Requests[i]
t.metrics.MessagesRcvd.Inc(1)
if pErr := t.handleRaftRequest(ctx, req, stream); pErr != nil {
if err := stream.Send(newRaftMessageResponse(req, pErr)); err != nil {
return err
}
t.metrics.ReverseSent.Inc(1)
}
}
}
}()
}); err != nil {
return err
}
select {
case err := <-errCh:
return err
case <-t.stopper.ShouldQuiesce():
return nil
}
}
// DelegateRaftSnapshot handles incoming delegated snapshot requests and passes
// the request to pass off to the sender store. Errors during the snapshots
// process are sent back as a response.
func (t *RaftTransport) DelegateRaftSnapshot(stream MultiRaft_DelegateRaftSnapshotServer) error {
ctx, cancel := t.stopper.WithCancelOnQuiesce(stream.Context())
defer cancel()
req, err := stream.Recv()
if err != nil {
return err
}
resp := t.InternalDelegateRaftSnapshot(ctx, req.GetSend())
err = stream.Send(resp)
if err != nil {
return err
}
return nil
}
// InternalDelegateRaftSnapshot processes requests in a request/response fashion for normal DelegateSnapshotRequests
func (t *RaftTransport) InternalDelegateRaftSnapshot(
ctx context.Context, req *kvserverpb.DelegateSendSnapshotRequest,
) *kvserverpb.DelegateSnapshotResponse {
if req == nil {
err := errors.New("client error: no message in first delegated snapshot request")
return &kvserverpb.DelegateSnapshotResponse{
Status: kvserverpb.DelegateSnapshotResponse_ERROR,
EncodedError: errors.EncodeError(context.Background(), err),
}
}
// Get the handler of the sender store.
handler, ok := t.getHandler(req.DelegatedSender.StoreID)
if !ok {
log.Warningf(
ctx,
"unable to accept Raft message: %+v: no handler registered for"+
" the sender store"+" %+v",
req.CoordinatorReplica.StoreID,
req.DelegatedSender.StoreID,
)
err := errors.New("unable to accept Raft message: no handler registered for the sender store")
return &kvserverpb.DelegateSnapshotResponse{
Status: kvserverpb.DelegateSnapshotResponse_ERROR,
EncodedError: errors.EncodeError(context.Background(), err),
}
}
// Pass off the snapshot request to the sender store.
return handler.HandleDelegatedSnapshot(ctx, req)
}
// RaftSnapshot handles incoming streaming snapshot requests.
func (t *RaftTransport) RaftSnapshot(stream MultiRaft_RaftSnapshotServer) error {
ctx, cancel := t.stopper.WithCancelOnQuiesce(stream.Context())
defer cancel()
req, err := stream.Recv()
if err != nil {
return err
}
if req.Header == nil {
err := errors.New("client error: no header in first snapshot request message")
return stream.Send(snapRespErr(err))
}
rmr := req.Header.RaftMessageRequest
handler, ok := t.getHandler(rmr.ToReplica.StoreID)
if !ok {
log.Warningf(ctx, "unable to accept Raft message from %+v: no handler registered for %+v",
rmr.FromReplica, rmr.ToReplica)
return kvpb.NewStoreNotFoundError(rmr.ToReplica.StoreID)
}
return handler.HandleSnapshot(ctx, req.Header, stream)
}
// Listen registers a raftMessageHandler to receive proxied messages.
func (t *RaftTransport) Listen(storeID roachpb.StoreID, handler RaftMessageHandler) {
t.handlers.Store(int64(storeID), unsafe.Pointer(&handler))
}
// Stop unregisters a raftMessageHandler.
func (t *RaftTransport) Stop(storeID roachpb.StoreID) {
t.handlers.Delete(int64(storeID))
}
// processQueue opens a Raft client stream and sends messages from the
// designated queue (ch) via that stream, exiting when an error is received or
// when it idles out. All messages remaining in the queue at that point are
// lost and a new instance of processQueue will be started by the next message
// to be sent.
func (t *RaftTransport) processQueue(
q *raftSendQueue, stream MultiRaft_RaftMessageBatchClient, class rpc.ConnectionClass,
) error {
errCh := make(chan error, 1)
ctx := stream.Context()
if err := t.stopper.RunAsyncTask(
ctx, "storage.RaftTransport: processing queue",
func(ctx context.Context) {
errCh <- func() error {
for {
resp, err := stream.Recv()
if err != nil {
return err
}
t.metrics.ReverseRcvd.Inc(1)
handler, ok := t.getHandler(resp.ToReplica.StoreID)
if !ok {
log.Warningf(ctx, "no handler found for store %s in response %s",
resp.ToReplica.StoreID, resp)
continue
}
if err := handler.HandleRaftResponse(ctx, resp); err != nil {
return err
}
}
}()
}); err != nil {
return err
}
maybeAnnotateWithAdmittedRaftLogEntries := func(
req *kvserverpb.RaftMessageRequest,
admitted []kvflowcontrolpb.AdmittedRaftLogEntries,
) {
if len(admitted) == 0 {
return // nothing to do
}
req.AdmittedRaftLogEntries = append(req.AdmittedRaftLogEntries, admitted...)
flowTokenDispatchCount := len(req.AdmittedRaftLogEntries)
if log.V(2) && flowTokenDispatchCount > 0 {
for i, admittedEntries := range req.AdmittedRaftLogEntries {
log.Infof(ctx, "informing n%s of below-raft %s: %d out of %d dispatches",
q.nodeID, admittedEntries,
i+1, flowTokenDispatchCount,
)
}
}
}
var sentInitialStoreIDs, sentAdditionalStoreIDs bool
maybeAnnotateWithStoreIDs := func(batch *kvserverpb.RaftMessageRequestBatch) {
shouldSendAdditionalStoreIDs := t.kvflowControl.setAdditionalStoreIDs.Load() && !sentAdditionalStoreIDs
if !sentInitialStoreIDs || shouldSendAdditionalStoreIDs {
t.kvflowControl.mu.RLock()
batch.StoreIDs = nil
batch.StoreIDs = append(batch.StoreIDs, t.kvflowControl.mu.localStoreIDs...)
t.kvflowControl.mu.RUnlock()
// Unconditionally set sentInitialStoreIDs, since we always have
// the initial store IDs before the additional ones.
sentInitialStoreIDs = true
// Mark that we've sent the additional store IDs, to not need to
// re-send it again.
sentAdditionalStoreIDs = shouldSendAdditionalStoreIDs
log.VInfof(ctx, 1, "informing n%d of %d local store ID(s) (%s) over the raft transport[%s]",
q.nodeID, len(batch.StoreIDs), roachpb.StoreIDSlice(batch.StoreIDs), class)
}
}
clearRequestBatch := func(batch *kvserverpb.RaftMessageRequestBatch) {
// Reuse the Requests slice, but zero out the contents to avoid delaying
// GC of memory referenced from within.
for i := range batch.Requests {
batch.Requests[i] = kvserverpb.RaftMessageRequest{}
}
batch.Requests = batch.Requests[:0]
batch.StoreIDs = nil
}
var raftIdleTimer timeutil.Timer
defer raftIdleTimer.Stop()
idleTimeout := raftIdleTimeout
if overrideFn := t.knobs.OverrideIdleTimeout; overrideFn != nil {
idleTimeout = overrideFn()
}
var dispatchPendingFlowTokensTimer timeutil.Timer
defer dispatchPendingFlowTokensTimer.Stop()
dispatchPendingFlowTokensTimer.Reset(kvadmission.FlowTokenDispatchInterval.Get(&t.st.SV))
dispatchPendingFlowTokensCh := dispatchPendingFlowTokensTimer.C
if t.knobs.TriggerFallbackDispatchCh != nil {
dispatchPendingFlowTokensCh = t.knobs.TriggerFallbackDispatchCh
}
batch := &kvserverpb.RaftMessageRequestBatch{}
for {
raftIdleTimer.Reset(idleTimeout)
select {
case <-t.stopper.ShouldQuiesce():
return nil
case <-raftIdleTimer.C:
raftIdleTimer.Read = true
return nil
case err := <-errCh:
return err
case req := <-q.reqs:
size := int64(req.Size())
q.bytes.Add(-size)
budget := targetRaftOutgoingBatchSize.Get(&t.st.SV) - size
var pendingDispatches []kvflowcontrolpb.AdmittedRaftLogEntries
if disableFn := t.knobs.DisablePiggyBackedFlowTokenDispatch; disableFn == nil || !disableFn() {
// Piggyback any pending flow token dispatches on raft transport
// messages already bound for the remote node. If the stream
// over which we're returning these flow tokens breaks, this is
// detected by the remote node, where tokens were originally
// deducted, who then frees up all held tokens (see I1 from
// kvflowcontrol/doc.go). If the stream is culled because it's
// idle, that's deducted remotely using the same stream-break
// mechanism. If there are no open streams to a given node and
// there's still pending flow tokens, we'll drop those tokens to
// reclaim memory in dropFlowTokensForDisconnectedNodes. For
// idle-but-not-culled connections, we have a fallback timer to
// periodically transmit one-off RaftMessageRequests for timely
// token returns.
pendingDispatches = t.kvflowControl.dispatchReader.PendingDispatchFor(q.nodeID)
maybeAnnotateWithAdmittedRaftLogEntries(req, pendingDispatches)
}
batch.Requests = append(batch.Requests, *req)
releaseRaftMessageRequest(req)
// Pull off as many queued requests as possible, within reason.
for budget > 0 {
select {
case req = <-q.reqs:
size := int64(req.Size())
q.bytes.Add(-size)
budget -= size
batch.Requests = append(batch.Requests, *req)
releaseRaftMessageRequest(req)
default:
budget = -1
}
}
maybeAnnotateWithStoreIDs(batch)
if err := stream.Send(batch); err != nil {
t.metrics.FlowTokenDispatchesDropped.Inc(int64(len(pendingDispatches)))
return err
}
t.metrics.MessagesSent.Inc(int64(len(batch.Requests)))
clearRequestBatch(batch)
case <-dispatchPendingFlowTokensCh:
dispatchPendingFlowTokensTimer.Read = true
dispatchPendingFlowTokensTimer.Reset(kvadmission.FlowTokenDispatchInterval.Get(&t.st.SV))
if disableFn := t.knobs.DisableFallbackFlowTokenDispatch; disableFn != nil && disableFn() {
continue // nothing to do
}
pendingDispatches := t.kvflowControl.dispatchReader.PendingDispatchFor(q.nodeID)
if len(pendingDispatches) == 0 {
continue // nothing to do
}
// TODO(irfansharif): There's no limit on how many pending
// dispatches are going to be attached to the outgoing raft
// messages, both here and above. It can be excessive -- limit this
// by some count/byte policy as part of #95563.
req := newRaftMessageRequest()
maybeAnnotateWithAdmittedRaftLogEntries(req, pendingDispatches)
batch.Requests = append(batch.Requests, *req)
releaseRaftMessageRequest(req)
maybeAnnotateWithStoreIDs(batch)
if err := stream.Send(batch); err != nil {
t.metrics.FlowTokenDispatchesDropped.Inc(int64(len(pendingDispatches)))
return err
}
t.metrics.MessagesSent.Inc(int64(len(batch.Requests)))
clearRequestBatch(batch)
if fn := t.knobs.OnFallbackDispatch; fn != nil {
fn()
}
case gotNodeID := <-t.knobs.MarkSendQueueAsIdleCh:
if q.nodeID == gotNodeID {
return nil
}
select {
// Echo the node ID back into MarkSendQueueAsIdleCh until it reaches
// a raftSendQueue for this ID. Only used in tests.
case t.knobs.MarkSendQueueAsIdleCh <- gotNodeID:
default:
}
}
}
}
// getQueue returns the queue for the specified node ID and a boolean
// indicating whether the queue already exists (true) or was created (false).
func (t *RaftTransport) getQueue(
nodeID roachpb.NodeID, class rpc.ConnectionClass,
) (*raftSendQueue, bool) {
queuesMap := &t.queues[class]
value, ok := queuesMap.Load(int64(nodeID))
if !ok {
t.kvflowControl.mu.Lock()
q := raftSendQueue{
reqs: make(chan *kvserverpb.RaftMessageRequest, raftSendBufferSize),
nodeID: nodeID,
}
value, ok = queuesMap.LoadOrStore(int64(nodeID), unsafe.Pointer(&q))
t.kvflowControl.mu.connectionTracker.markNodeConnected(nodeID, class)
t.kvflowControl.mu.Unlock()
}
return (*raftSendQueue)(value), ok
}
// SendAsync sends a message to the recipient specified in the request. It
// returns false if the outgoing queue is full. The returned bool may be a false
// positive but will never be a false negative; if sent is true the message may
// or may not actually be sent but if it's false the message definitely was not
// sent. It is not safe to continue using the reference to the provided request.
func (t *RaftTransport) SendAsync(
req *kvserverpb.RaftMessageRequest, class rpc.ConnectionClass,
) (sent bool) {
toNodeID := req.ToReplica.NodeID
defer func() {
if !sent {
t.metrics.MessagesDropped.Inc(1)
releaseRaftMessageRequest(req)
}
}()
if req.RangeID == 0 && len(req.Heartbeats) == 0 && len(req.HeartbeatResps) == 0 {
// Coalesced heartbeats are addressed to range 0; everything else
// needs an explicit range ID.
panic("only messages with coalesced heartbeats or heartbeat responses may be sent to range ID 0")
}
if req.Message.Type == raftpb.MsgSnap {
panic("snapshots must be sent using SendSnapshot")
}
if !t.dialer.GetCircuitBreaker(toNodeID, class).Ready() {
return false
}
q, existingQueue := t.getQueue(toNodeID, class)
if !existingQueue {
// Note that startProcessNewQueue is in charge of deleting the queue.
ctx := t.AnnotateCtx(context.Background())
if !t.startProcessNewQueue(ctx, toNodeID, class) {
return false
}
}
// Note: computing the size of the request *before* sending it to the queue,
// because the receiver takes ownership of, and can modify it.
size := int64(req.Size())
select {
case q.reqs <- req:
q.bytes.Add(size)
return true
default:
if logRaftSendQueueFullEvery.ShouldLog() {
log.Warningf(t.AnnotateCtx(context.Background()), "raft send queue to n%d is full", toNodeID)
}
return false
}
}
// startProcessNewQueue connects to the node and launches a worker goroutine
// that processes the queue for the given nodeID (which must exist) until
// the underlying connection is closed or an error occurs. This method
// takes on the responsibility of deleting the queue when the worker shuts down.
// The class parameter dictates the ConnectionClass which should be used to dial
// the remote node. Traffic for system ranges and heartbeats will receive a
// different class than that of user data ranges.
//
// Returns whether the worker was started (the queue is deleted either way).
func (t *RaftTransport) startProcessNewQueue(
ctx context.Context, toNodeID roachpb.NodeID, class rpc.ConnectionClass,
) (started bool) {
cleanup := func(q *raftSendQueue) {
// Account for the remainder of `ch` which was never sent.
// NB: we deleted the queue above, so within a short amount
// of time nobody should be writing into the channel any
// more. We might miss a message or two here, but that's
// OK (there's nobody who can safely close the channel the
// way the code is written).
for {
select {
case req := <-q.reqs:
q.bytes.Add(-int64(req.Size()))
t.metrics.MessagesDropped.Inc(1)
releaseRaftMessageRequest(req)
default:
return
}
}
}
worker := func(ctx context.Context) {
q, existingQueue := t.getQueue(toNodeID, class)
if !existingQueue {
log.Fatalf(ctx, "queue for n%d does not exist", toNodeID)
}
defer func() {
if fn := t.knobs.OnWorkerTeardown; fn != nil {
fn(toNodeID)
}
}()
defer cleanup(q)
defer func() {
t.kvflowControl.mu.Lock()
t.queues[class].Delete(int64(toNodeID))
t.kvflowControl.mu.connectionTracker.markNodeDisconnected(toNodeID, class)
t.kvflowControl.mu.Unlock()
}()
// NB: we dial without a breaker here because the caller has already
// checked the breaker. Checking it again can cause livelock, see:
// https://github.com/cockroachdb/cockroach/issues/68419
conn, err := t.dialer.DialNoBreaker(ctx, toNodeID, class)
if err != nil {
// DialNode already logs sufficiently, so just return.
return
}
client := NewMultiRaftClient(conn)
batchCtx, cancel := context.WithCancel(ctx)
defer cancel()
stream, err := client.RaftMessageBatch(batchCtx) // closed via cancellation
if err != nil {
log.Warningf(ctx, "creating batch client for node %d failed: %+v", toNodeID, err)
return
}
if err := t.processQueue(q, stream, class); err != nil {
log.Warningf(ctx, "while processing outgoing Raft queue to node %d: %s:", toNodeID, err)
}
}
err := t.stopper.RunAsyncTask(ctx, "storage.RaftTransport: sending/receiving messages",
func(ctx context.Context) {
pprof.Do(ctx, pprof.Labels("remote_node_id", toNodeID.String()), worker)
})
if err != nil {
t.kvflowControl.mu.Lock()
t.queues[class].Delete(int64(toNodeID))
t.kvflowControl.mu.connectionTracker.markNodeDisconnected(toNodeID, class)
t.kvflowControl.mu.Unlock()
return false
}
return true
}
// startDroppingFlowTokensForDisconnectedNodes kicks of an asynchronous worker
// that periodically scans for nodes we're no longer connected to, and if there
// are any pending flow tokens bound for that node, it simply drops them. This
// "connected nodes" is a client-side view of the world. On the server-side when
// gRPC streams disconnect, we release all held tokens. So simply dropping these
// pending dispatches on the client side does not cause token leaks, and exists
// to prevent an unbounded accumulation of memory.
func (t *RaftTransport) startDroppingFlowTokensForDisconnectedNodes(ctx context.Context) error {
return t.stopper.RunAsyncTask(
ctx,
"kvserver.RaftTransport: drop flow tokens for disconnected nodes",
func(ctx context.Context) {
settingChangeCh := make(chan struct{}, 1)
kvadmission.FlowTokenDropInterval.SetOnChange(
&t.st.SV, func(ctx context.Context) {
select {
case settingChangeCh <- struct{}{}:
default:
}
})
timer := timeutil.NewTimer()
defer timer.Stop()
for {
interval := kvadmission.FlowTokenDropInterval.Get(&t.st.SV)
if interval > 0 {
timer.Reset(interval)
} else {
// Disable the mechanism.
timer.Stop()
timer = timeutil.NewTimer()
}
select {
case <-timer.C:
timer.Read = true
t.dropFlowTokensForDisconnectedNodes()
continue