From f1ce08ef63a4c26d16dc0bd920ce510df11fc0dc Mon Sep 17 00:00:00 2001 From: laurentlb Date: Tue, 28 May 2019 10:52:31 -0700 Subject: [PATCH] Flip the flag --incompatible_no_kwargs_in_build_files Fixes https://github.com/bazelbuild/bazel/issues/8021 RELNOTES: --incompatible_no_kwargs_in_build_files is enabled by default PiperOrigin-RevId: 250317931 --- .../devtools/build/lib/packages/StarlarkSemanticsOptions.java | 2 +- .../com/google/devtools/build/lib/syntax/StarlarkSemantics.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java b/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java index 2a64d89df2ae8d..143904c9b8c906 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java +++ b/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java @@ -494,7 +494,7 @@ public class StarlarkSemanticsOptions extends OptionsBase implements Serializabl @Option( name = "incompatible_no_kwargs_in_build_files", - defaultValue = "false", + defaultValue = "true", documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS, effectTags = {OptionEffectTag.BUILD_FILE_SEMANTICS}, metadataTags = { diff --git a/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java b/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java index 55b2234f9dc91d..eb6b5490dd56e6 100644 --- a/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java +++ b/src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java @@ -246,7 +246,7 @@ public static Builder builderWithDefaults() { .incompatibleExpandDirectories(true) .incompatibleNewActionsApi(true) .incompatibleNoAttrLicense(true) - .incompatibleNoKwargsInBuildFiles(false) + .incompatibleNoKwargsInBuildFiles(true) .incompatibleNoOutputAttrDefault(true) .incompatibleNoSupportToolsInActionInputs(false) .incompatibleNoTargetOutputGroup(false)