Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise not to remove Sentinel? #865

Open
maartenbreddels opened this issue Sep 15, 2023 · 0 comments
Open

Promise not to remove Sentinel? #865

maartenbreddels opened this issue Sep 15, 2023 · 0 comments

Comments

@maartenbreddels
Copy link
Contributor

In bbbdfbb Sentinel was made deprecated. In the warning it mentions it might be removed "It was published by mistake, and may be removed in the future.".

Sentinel is already used in traittypes, and now people are afraid this will cause a breakage in the future:

I think there is a tendency in the Python community to remove deprecated 'things', I think we should not do that.
Instead, we should try not to touch the deprecated parts, especially if they are 'islands of code' like the Sentinel class is, since it would not increase the maintainance burden at all I think.

Removal and renaming have caused a lot of pain and suffering for library maintainers and users and caused a lot of trust issues.

I suggest we either promise to not remove it, or mention we try to not do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant