Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPykernel 6.9.0 generates error when Python errors are returned after execution #860

Closed
ccordoba12 opened this issue Feb 9, 2022 · 4 comments · Fixed by #861
Closed
Labels

Comments

@ccordoba12
Copy link
Member

ccordoba12 commented Feb 9, 2022

This is very simple to reproduce in QtConsole. After executing something like this:

imagen

you'll see the following traceback in the terminal where it was started

Traceback (most recent call last):
  File "/home/carlos/miniconda3/envs/py310/lib/python3.10/site-packages/ipykernel/kernelbase.py", line 461, in dispatch_queue
    await self.process_one()
  File "/home/carlos/miniconda3/envs/py310/lib/python3.10/site-packages/ipykernel/kernelbase.py", line 450, in process_one
    await dispatch(*args)
TypeError: object NoneType can't be used in 'await' expression

I can't reproduce this in 6.8.0 or older versions and it's not related to the Python version I'm using (it was also reproduced in 3.8, as reported here).

I'd say this was introduced in PR #853, but I don't know how to fix it.

@blink1073
Copy link
Contributor

cc @minrk

@blink1073 blink1073 added the bug label Feb 9, 2022
@minrk
Copy link
Member

minrk commented Feb 11, 2022

Creating a test env to see if I can track it down, but 90% sure something still has await self._abort_queues() which is no longer a coroutine. Adding async def back would fix that, but I'd like to take a minute to understand it first.

@ccordoba12
Copy link
Member Author

No problem. Thanks for taking a look at this @minrk!

@minrk
Copy link
Member

minrk commented Feb 11, 2022

I was close! Right issue, wrong function. Fixed by #861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants