Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use of zmq zero-copy is no longer correct #1278

Closed
minrk opened this issue Oct 22, 2024 · 0 comments · Fixed by #1280
Closed

use of zmq zero-copy is no longer correct #1278

minrk opened this issue Oct 22, 2024 · 0 comments · Fixed by #1280
Labels

Comments

@minrk
Copy link
Member

minrk commented Oct 22, 2024

the switch from ZMQStream to async Socket in #1079 has resulted in always receiving all messages with copy=True, but there are checks for isinstance(always_bytes_object, zmq.Message) which always results in copy=True.

This can get costly because inproc sends with copy=False are particularly lightweight, whereas the new unconditional copy plus additional inproc send/recv for subshells result in at least two additional in-memory copies of every message frame received by the kernel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant