Replies: 1 comment
-
Or, alternatively, we could modify the validation routines and add some exception logic: If the attribute is in some YAML list, ignore it That’s even simpler |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Working on #1646 the deceptively simple request to "not define interface.type" poses some interesting challenges
interface.type
including "lag" to keep validation from failinginterface.type
, we need to ensure the lag module creates its interfaces after validation.This means refactoring (splitting) and doing the interface creation in
module_pre_link_transform
pre_link_transform
runs. OK, so I refactored that to postpone that logic untillink_pre_link_transform
(merging in the existing method)vlan-trunk-attribute-error
test case fails, because the validation logic no longer sees the user provided interface attributes (as processing has been postponed)As you can imagine, all of the above is fixable, but it leads to a massive PR with lots of changes. And while I could split that up and separate out the vlan module changes, I'm thinking the easier and cleaner solution is to just rename "type" to "_type" and leave the rest as-is - until a final post-processing step where we rename
_type
totype
such that the templates can remain the sameThoughts? See #1653 for code impact
Beta Was this translation helpful? Give feedback.
All reactions