Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

add go-car impl url #69

Closed
wants to merge 1 commit into from
Closed

add go-car impl url #69

wants to merge 1 commit into from

Conversation

daviddias
Copy link
Member

@whyrusleeping can you give a pass through the spec and see if it matches your implementation and update if needed?

@whyrusleeping
Copy link
Contributor

@diasdavid no, this does not match my impl. This is not a spec, it is a draft, and was never finalized (why is it merged?)

cc @Stebalien

@whyrusleeping
Copy link
Contributor

Ah, you merged it @diasdavid. See comments here: #51 (comment)

@Stebalien
Copy link
Contributor

Yeah, @whyrusleeping's impl is just tar. Not the best solution but it works, exists, and very much doesn't suffer from NIH.

@daviddias
Copy link
Member Author

Got it. Added the label WIP to it. d2f7b50

@rvagg
Copy link
Member

rvagg commented Aug 14, 2019

The CAR spec was removed in #72 so this is no longer a valid PR so I'm closing this. However, I think we might need to bring it back since it's in active use for Filecoin genesis. I've also created a ZIP CAR that's very similar but conforms to the Datastore interface and I have implementations in both JavaScript and Go, mainly for cross-language test fixtures, but I might spec that up too.

@rvagg rvagg closed this Aug 14, 2019
@rvagg rvagg deleted the go-car branch August 14, 2019 08:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants