Skip to content
This repository has been archived by the owner on Aug 24, 2021. It is now read-only.

chore: change from callbacks to promises #38

Closed
wants to merge 1 commit into from

Conversation

reconbot
Copy link

@vmx
Copy link
Member

vmx commented Jan 14, 2019

Thanks @reconbot for your contribution! I sadly can't merge this right away, as the IPLD project is taking the change of also making other API changes to the format. ipld/interface-ipld-format#50 contains more information about those.

My plan is to get the top-level API working first (ipld/js-ipld#185) and then updates all those formats. That will be a lot of work and any help will be appreciated once we get there.

I'll do a proper review of this PR, once I know what changes will exactly be needed (I'll port ipld-dag-pb first.

Sorry for not communicating this more clearly earlier.

@reconbot
Copy link
Author

Yeah no worries, looks like I should close this in the meantime. =)

@reconbot reconbot closed this Jan 15, 2019
@reconbot reconbot deleted the reconbot/promises branch January 15, 2019 19:43
@reconbot reconbot restored the reconbot/promises branch January 15, 2019 19:44
@reconbot reconbot reopened this Jan 15, 2019
@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@c370777). Click here to learn what that means.
The diff coverage is 84.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #38   +/-   ##
=========================================
  Coverage          ?   93.68%           
=========================================
  Files             ?        7           
  Lines             ?      285           
  Branches          ?        0           
=========================================
  Hits              ?      267           
  Misses            ?       18           
  Partials          ?        0
Impacted Files Coverage Δ
src/util/commit.js 95.89% <62.5%> (ø)
src/util/tree.js 93.93% <71.42%> (ø)
src/util.js 89.74% <78.94%> (ø)
src/util/tag.js 95.23% <80%> (ø)
src/resolver.js 93.1% <92.15%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c370777...5a46136. Read the comment docs.

@reconbot
Copy link
Author

Just reread your comment, I'll keep this open for you =)

@vmx
Copy link
Member

vmx commented May 8, 2019

This is superseded by #51. Though thanks for your contribution @reconbot!

@vmx vmx closed this May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants