You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
This causes issues when things are moved across the message channel, because even fields that were Buffer's come up as Uint8Arrays on the other end. For this reason I would like to propose a change which would treat Uint8Array (and I'm inclined to suggest other ArrayBuffer views as well) as a binary data instead (same as Buffers is treated today).
It is worth pointing out that ArrayBuffer itself will appear as {byteLength:number} which I don't think is ideal, but probably out of scope.
The text was updated successfully, but these errors were encountered:
At the moment
Uint8Array
(or any other view ofArrayBuffer
seems to be treated as array of numbers)js-ipld-dag-cbor/src/util.js
Lines 37 to 48 in 5d3389a
This causes issues when things are moved across the message channel, because even fields that were
Buffer
's come up asUint8Array
s on the other end. For this reason I would like to propose a change which would treatUint8Array
(and I'm inclined to suggest otherArrayBuffer
views as well) as a binary data instead (same asBuffer
s is treated today).It is worth pointing out that
ArrayBuffer
itself will appear as{byteLength:number}
which I don't think is ideal, but probably out of scope.The text was updated successfully, but these errors were encountered: