Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema/gen/go: batch file writes via a bytes.Buffer #161

Merged
merged 1 commit into from
Apr 9, 2021
Merged

schema/gen/go: batch file writes via a bytes.Buffer #161

merged 1 commit into from
Apr 9, 2021

Commits on Apr 9, 2021

  1. schema/gen/go: batch file writes via a bytes.Buffer 

    With this change, running 'go generate ./...' on the entire module while
running gopls on one of its files drops gopls's CPU spinning from ~25s
to well under a second. They should improve that anyway, but there's no
reason for the tens of thousands of tiny FS writes on our end either.

The time to run 'go generate ./...' itself is largely unaffected; it
goes from ~1.2s to ~1.1s, judging by a handful of runs.
    @mvdan
    mvdan committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    88f72f5 View commit details
    Browse the repository at this point in the history