Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codecs: change examples, tests, documents to use top-level Encode & Decode #428

Open
rvagg opened this issue May 23, 2022 · 0 comments
Open

codecs: change examples, tests, documents to use top-level Encode & Decode #428

rvagg opened this issue May 23, 2022 · 0 comments
Assignees
@rvagg
Labels
P1 High: Likely tackled by core team if no one steps up

Comments

@rvagg
Copy link
Member

rvagg commented May 23, 2022

Introduced in #232, aside from providing []byte forms (nice), they also handle the TypedNode Representation() conversion before encoding. But we don't really use them or recommend them anywhere. They really should be the standard way of interacting with codecs.

We should also chase up other instances of direct codec usage and replace them too, anywhere where we're doing .Representation() should probably be switched out for these to encourage users on best practice.

Related: #191 & #196
@rvagg rvagg moved this to 🥞 Todo in IPLD team's weekly tracker May 23, 2022
@rvagg rvagg self-assigned this May 23, 2022
@rvagg rvagg added the P1 High: Likely tackled by core team if no one steps up label May 23, 2022
rvagg added a commit to ipfs/go-graphsync that referenced this issue May 27, 2022
@rvagg
chore(ipld): switch to using top-level ipld-prime codec helpers
36a159c 
Ref: ipld/go-ipld-prime#428
@rvagg rvagg mentioned this issue May 27, 2022
Merged
hannahhoward added a commit to ipfs/go-graphsync that referenced this issue May 31, 2022
@rvagg @hannahhoward
chore(ipld): switch to using top-level ipld-prime codec helpers (#383)
fa5a9f2 
* chore(ipld): switch to using top-level ipld-prime codec helpers

Ref: ipld/go-ipld-prime#428

* fixup! chore(ipld): switch to using top-level ipld-prime codec helpers

Co-authored-by: Hannah Howard <[email protected]>
@rvagg rvagg moved this from 🥞 Todo to 🗄️ Backlog in IPLD team's weekly tracker Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rvagg rvagg

Labels
P1 High: Likely tackled by core team if no one steps up
Projects
IPLD team's weekly tracker
Status: 🗄️ Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rvagg