Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockstore: OpenReadOnly shouldn't need to parse the entire index into memory in some cases #222

Open
mvdan opened this issue Sep 7, 2021 · 1 comment
Labels
P3 Low: Not priority right now

Comments

@mvdan
Copy link
Contributor

mvdan commented Sep 7, 2021

Right now we always read and unmarshal an existing whole index into memory.

Luckily, IndexSorted is designed to allow using directly as a mmapped []byte from disk. If OpenReadOnly is called with a carv2 file that has a sorted index, we should use the index straight from the mmap.

cc @masih @willscott

@masih
Copy link
Member

masih commented Sep 7, 2021

Relates to #95

@rvagg rvagg added the P3 Low: Not priority right now label May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low: Not priority right now
Projects
None yet
Development

No branches or pull requests

3 participants