Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2: don't expose bits of API that shouldn't be used directly #118

Closed
mvdan opened this issue Jun 29, 2021 · 1 comment · Fixed by #151
Closed

v2: don't expose bits of API that shouldn't be used directly #118

mvdan opened this issue Jun 29, 2021 · 1 comment · Fixed by #151
Labels
v2-before-release
Milestone
CARv2 v2.0.0

Comments

@mvdan
Copy link
Contributor

mvdan commented Jun 29, 2021

For example, the insertion index is only used by the incremental read-write blockstore, and is not specced, so it should never be used while encoding CARv2 files. Having it as part of the public API is dangerous - if someone misses that detail, they could encode a CARv2 with such an index directly, which would be unspecified and fragile.
@mvdan mvdan added this to the CAR v2 milestone Jun 29, 2021
This was referenced Jul 9, 2021
Merged
Merged
@masih masih linked a pull request Jul 13, 2021 that will close this issue
Unexport unecesserry index APIs and integrate with mulitcodec #151
Merged
@masih
Copy link
Member

masih commented Jul 16, 2021

Done

@masih masih closed this as completed Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v2-before-release
Projects
None yet
Milestone
CARv2 v2.0.0
Development

Successfully merging a pull request may close this issue.

Unexport unecesserry index APIs and integrate with mulitcodec
2 participants
@masih @mvdan