Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input format validation doesn't match up with expected format #66

Closed
achingbrain opened this issue Feb 28, 2024 · 2 comments · Fixed by #202
Closed

Input format validation doesn't match up with expected format #66

achingbrain opened this issue Feb 28, 2024 · 2 comments · Fixed by #202
Assignees
Milestone

Comments

@achingbrain
Copy link
Member

Hitting https://ipfs.sw.sgtpooki.com tells you to use a /ipfs/bafk.../path/to/file-style IPFS path:

image

Filling in the field with an IPFS path tells you to use a ipfs://-style IPFS URI:

image

Switching to an IPFS URI tells you to use an IPFS path:

image
@achingbrain achingbrain changed the title Input format validation doesn't match up with expected format: Input format validation doesn't match up with expected format Feb 28, 2024
@achingbrain
Copy link
Member Author

This will resolve part of the problem - ipfs/helia-verified-fetch#4

Input validation should be relaxed to accept more than just /ip[f|n]s/...

@SgtPooki
Copy link
Member

@achingbrain I think that helper-ui may go away or change eventually. But yea, accepting proper formats or updating that input to accept the changes we've made with adopting @helia/verified-fetch would be a good thing until that change.

@SgtPooki SgtPooki added this to the Alpha milestone Apr 8, 2024
@SgtPooki SgtPooki self-assigned this Apr 15, 2024
@SgtPooki SgtPooki linked a pull request Apr 16, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants