Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A buuunch of stuff #7

Closed
wants to merge 1 commit into from
Closed

A buuunch of stuff #7

wants to merge 1 commit into from

Conversation

daviddias
Copy link
Member

  • start using dist.ipfs.io in favor of go-builder
  • zip -> tar.gz
  • remove non used features (cli tool), simplifies a lot of things
  • update documentation

//cc @jbenet

@jbenet
Copy link
Member

jbenet commented Apr 8, 2016

(discussed in person.) todo:

  • create separate module: go-ipfs-dep for project dependencies
  • keep go-ipfs module for installing the binary
  • still update this module to work with dist.ipfs.io

@jbenet
Copy link
Member

jbenet commented Dec 1, 2016

@diasdavid what needs to happen here? what's stalled?

@jbenet
Copy link
Member

jbenet commented Dec 1, 2016

and every version should be released, too. all of these should work:

npm install -g [email protected]
npm install -g [email protected]
npm install -g [email protected]
npm install -g [email protected]
npm install -g [email protected]

@jbenet
Copy link
Member

jbenet commented Dec 1, 2016

remove non used features (cli tool), simplifies a lot of things

why? it is used.

// hacky hack hack to work around unpublishability
version = version.replace(/-[0-9]+/, '')

var filename = 'ipfs_v' + version + '_' + goenv.GOOS + '-' + goenv.GOARCH + '.tar.gz'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't work for windows. go-ipfs uses .zip for windows.

switch (goenv.GOOS) {
case 'darwin':
case 'linux':
case 'freebsd':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

windows builds exist now.

@daviddias
Copy link
Member Author

daviddias commented Dec 1, 2016

remove non used features (cli tool), simplifies a lot of things
jbennet: why? it is used.

This PR was made before go-ipfs-dep, it was making npm-go-ipfs the go-ipfs-dep, but then we made it, so not everything makes sense. (date of PR: April 8)

@haadcode is revisiting all of this dependency madness to install go-ipfs in JS land as part of "Improving Init" which evolved to that -- ipfs/js-ipfs#556 --.

@jbenet
Copy link
Member

jbenet commented Dec 1, 2016

Ok. i'm fixing this. this is breaking people's stuff.

@jbenet
Copy link
Member

jbenet commented Dec 1, 2016

@diasdavid no, this has nothing to do with all that madness. this just has to do with installing the binary, which was broken and forgotten for no good reason.

@jbenet jbenet closed this Dec 1, 2016
@jbenet jbenet deleted the update/0.4.0 branch December 1, 2016 08:40
@jbenet jbenet restored the update/0.4.0 branch December 1, 2016 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants