-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A buuunch of stuff #7
Conversation
(discussed in person.) todo:
|
@diasdavid what needs to happen here? what's stalled? |
and every version should be released, too. all of these should work:
|
why? it is used. |
// hacky hack hack to work around unpublishability | ||
version = version.replace(/-[0-9]+/, '') | ||
|
||
var filename = 'ipfs_v' + version + '_' + goenv.GOOS + '-' + goenv.GOARCH + '.tar.gz' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't work for windows. go-ipfs uses .zip
for windows.
switch (goenv.GOOS) { | ||
case 'darwin': | ||
case 'linux': | ||
case 'freebsd': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
windows builds exist now.
This PR was made before @haadcode is revisiting all of this dependency madness to install go-ipfs in JS land as part of "Improving Init" which evolved to that -- ipfs/js-ipfs#556 --. |
Ok. i'm fixing this. this is breaking people's stuff. |
@diasdavid no, this has nothing to do with all that madness. this just has to do with installing the binary, which was broken and forgotten for no good reason. |
//cc @jbenet