Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 0.4.x #10

Closed
harlantwood opened this issue Jul 31, 2016 · 12 comments
Closed

release 0.4.x #10

harlantwood opened this issue Jul 31, 2016 · 12 comments
Assignees

Comments

@harlantwood
Copy link

No description provided.

@jbenet
Copy link
Member

jbenet commented Jul 31, 2016

wait, why isn't this happening!? it's part of the go-ipfs release checklist https://github.com/ipfs/go-ipfs/blob/master/docs/releases.md

cc @whyrusleeping @Kubuxu ??

@whyrusleeping whyrusleeping self-assigned this Aug 4, 2016
@whyrusleeping
Copy link
Member

It appears this doesnt happen because this package relies on gobuilder

@whyrusleeping
Copy link
Member

@diasdavid mentioned there was a different npm package for getting the go-ipfs daemon in javascript.

@daviddias
Copy link
Member

js-ipfsd-ctl relies on go-ipfs-dep now, it is a simpler version of npm-go-ipfs that works with dist.ipfs.io instead of go-builder.

For now it is just 0.4.1, as we can't update to 0.4.2 due to a bug in 0.4.2.

@JGAntunes is doing a really awesome work of upgrading js-ipfsd-ctl to use binwrapper, that will solve the Arch problem ipfs/js-ipfsd-ctl#89

I'll go ahead an update this module description to point to go-ipfs-dep.

@harlantwood
Copy link
Author

@diasdavid if I read this correctly, I understand that:

  1. this module ( https://github.com/ipfs/npm-go-ipfs ) is deprecated
  2. https://github.com/diasdavid/go-ipfs-dep is the replacement

Correct?

@paul90
Copy link

paul90 commented Oct 11, 2016

Looks as if this is still not resolved.

If this module is deprecated then it needs a deprecate message adding in npm to point to the correct place. Also the readme there needs updating to install the correct npm package, and not this one.

@jbenet
Copy link
Member

jbenet commented Dec 1, 2016

guys, come on! people depend on this module-- including me. it wasted 20min of my time to realize that this was go-ipfs 0.3x being installed...

@jbenet
Copy link
Member

jbenet commented Dec 1, 2016

this module should not be deprecated-- why do people think it is? the goal of this module is to enable this:

> npm install go-ipfs
> node_modules/.bin/ipfs version

and this

> npm install -g go-ipfs
> ipfs version

as the readme says, to install go-ipfs. it should be using dist.ipfs.io

@jbenet
Copy link
Member

jbenet commented Dec 1, 2016

I'm on this, fixing it.

@jbenet
Copy link
Member

jbenet commented Dec 1, 2016

Okay, fixed. I published:

0.4.0 as 0.4.0-hacky2
0.4.1 as 0.4.1-hacky2
0.4.2 as 0.4.2-npmfix2
0.4.3 as 0.4.3-npmfix1
0.4.4 as 0.4.4

sorry for the silly version suffixes.


> npm view go-ipfs versions

[ '0.2.3',
  '0.2.4',
  '0.2.5',
  '0.2.6',
  '0.2.7',
  '0.2.8',
  '0.2.9',
  '0.2.10',
  '0.2.11',
  '0.3.0',
  '0.3.2-2',
  '0.3.2',
  '0.3.4-2',
  '0.3.4-3',
  '0.3.4',
  '0.3.5-2',
  '0.3.5',
  '0.3.6-1',
  '0.3.6-2',
  '0.3.6',
  '0.3.7-2',
  '0.3.7-3',
  '0.3.7-fix',
  '0.3.7',
  '0.3.8-1',
  '0.3.8',
  '0.3.9',
  '0.3.10',
  '0.3.11',
  '0.4.0-hacky2',
  '0.4.1-hacky2',
  '0.4.2-npmfix2',
  '0.4.3-npmfix1',
  '0.4.4' ]

@jbenet jbenet closed this as completed Dec 1, 2016
@harlantwood
Copy link
Author

Awesome, thanks. For the record, this is exactly what I want too: an executable that can be run from the shell, but managed via NPM.

@harlantwood
Copy link
Author

wait, why isn't this happening!? it's part of the go-ipfs release checklist https://github.com/ipfs/go-ipfs/blob/master/docs/releases.md

Not sure where to properly file this, but maybe there could be a check on CI that would fail if all of the steps for a given release were not completed (at least those, like this one, that are easy to check automatically).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants