go-namesys v0.1.1 #8057
Merged
go-namesys v0.1.1 #8057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it is preferable to retag go-namesys, this PR can wait for that and be updated after. |
Closed
lidel
force-pushed
the
fix/improve-resolve-error
branch
from
6ce6ed3 to
79de5ff
Compare
lidel
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
Tagged go-namesys v0.1.1 and rebased this PR to use that.
This PR includes both ipfs/go-namesys#9 and ipfs/go-namesys#8 – tested both again locally, works as expected 👍
$ ipfs resolve -r /ipns/ipfs.eth
/ipfs/bafybeiddamod5xk4uipjz52xodu4z62ul5xk6lzo3qaiz32yc3t6vd7xqa
$ ipfs resolve -r /ipns/google.com
Error: could not resolve name: "google.com" is missing a DNSLink record (https://docs.ipfs.io/concepts/dnslink/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version has an improved resolve error and fixes #8000
Changelog: https://github.com/ipfs/go-namesys/releases/tag/v0.1.1