blockstore: change unit of bloom filter to byte from bits #3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
added
status/in-progress
| HasBloomFilterHashes int // No size, 7 is usually best, consult bloom papers | ||
| HasARCCacheSize int // 32 bytes | ||
| } | ||
|
|
||
| func DefaultCacheOpts() CacheOpts { | ||
| return CacheOpts{ | ||
| HasBloomFilterSize: 512 * 8 * 1024, |
There was a problem hiding this comment.
I prefer using shift notation for these: 512 << 10
|
One small nitpick, doesnt need to be addressed, LGTM |
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
feat/config/bloombytes
branch
from
96a90f1
to
27279cd
Compare
|
Addressed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Jakub Sztandera [email protected]