Fix test str contains #2204
Merged
Fix test str contains #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Christian Couder <[email protected]>
License: MIT Signed-off-by: Christian Couder <[email protected]>
chriscool
force-pushed
the
fix-test-str-contains
branch
from
d16c23e to
e620115
Compare
|
Ok, there was a problem with my last patch. The tests should pass now. |
License: MIT Signed-off-by: Christian Couder <[email protected]>
|
LGTM thanks |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
t0081-repo-pinning.sh looks buggy to me without those 2 fixes.
Because when we grep for just "direct", it matches "indirect":
Unfortunately with those 2 fixes, now some tests are failing. This either means that we have bugs in go-ipfs that were previously hidden or that the tests that fail are wrong.
cc @whyrusleeping @jbenet