Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to go-ipld-prime #7909

Closed
oed opened this issue Feb 9, 2021 · 7 comments
Closed

Migrate to go-ipld-prime #7909

oed opened this issue Feb 9, 2021 · 7 comments
Labels
epic kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked topic/meta Topic meta

Comments

@oed
Copy link

oed commented Feb 9, 2021

I noticed that there was not issue explicitly tracking support for go-ipld-prime, so I created this issue. Looks like #6208 mentions it but not as a primary focus.

Would like to understand what the timeline for this looks like. I'm currently blocked from using go-ipfs because my project requires the dag-jose ipld codec, which is implemented for go-ipld-prime.

@oed oed added the kind/enhancement A net-new feature or improvement to an existing feature label Feb 9, 2021
@welcome
Copy link

welcome bot commented Feb 9, 2021

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@Stebalien Stebalien added the topic/meta Topic meta label Feb 12, 2021
@Stebalien
Copy link
Member

There are a few teams looking into this, but yeah, we should have a tracking issue.

@willscott
Copy link
Contributor

@oed - do you have specific interfaces to the go-ipfs library / cli that you hope to use but can't because they're currently not ipld-prime aware?

I'm starting to try to scope scope getting the interfaces ipld-prime aware so that ipld.Node's can be passed in and out, and it would be good to make sure that what happens in that scoping unblocks you

@oed
Copy link
Author

oed commented Feb 13, 2021

@willscott We have an implementation of go-dag-jose here: https://github.com/alexjg/go-dag-jose
If your work makes it possible to use this codec, which is made for ipld-prime, in the current ipfs implementation that would be perfect!

@jacobheun jacobheun added the status/ready Ready to be worked label Feb 22, 2021
@willscott willscott added the epic label Feb 22, 2021
@willscott
Copy link
Contributor

@hannahhoward, @gammazero, @acruikshank, and @mvdan and I are starting to dig into what needs to happen here.

We've put together an initial inventory of the packages with ipld-format dependencies. The first milestone we're breaking off is becoming opinionated with what interface we want to replace the current DagService with.

@oed
Copy link
Author

oed commented Aug 19, 2021

I guess this can be closed now, or when 0.10 is released 🎉

@willscott
Copy link
Contributor

Would be great to hear your experience of dag-jose codec working in the current master. Are you able to get it integrated as a plugin?

You're right though that this issue can be closed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic kind/enhancement A net-new feature or improvement to an existing feature status/ready Ready to be worked topic/meta Topic meta
Projects
None yet
Development

No branches or pull requests

4 participants