Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick UX feedback for pnet #3404

Open
jbenet opened this issue Nov 21, 2016 · 7 comments
Open

Quick UX feedback for pnet #3404

jbenet opened this issue Nov 21, 2016 · 7 comments

Comments

@jbenet
Copy link
Member

jbenet commented Nov 21, 2016

This is an issue to gather feedback for @Kubuxu on the pnet demo, and implementation.


  1. Daemon output should show that it's using a key.
    • something like Private network: shared-key <hash-of-key>
    • or something like Private network: shared-key <fingerprint-of-key>
    • or at least something like: Private network: shared-key <fs-path-to-key>
  2. Print out errors or warnings when a connection is attempted that fails.
    • would be nice to get a sense of how many connections are attempted with wrong keys
    • helps you notice you have the wrong bootstrap nodes on (if you dial out)
    • helps you notice incoming dials from others
    • helps you notice why your friend cannot connect to you
  3. may be useful to have a tool like ipfs-key-gen or libp2p-key-gen that is able to
    make the keys. (and mount this in ipfs at ipfs swarm key or something).
@jbenet
Copy link
Member Author

jbenet commented Nov 21, 2016

If using visual fingerprints, i'd love to be able to turn on a variable to "show as emoji" or something 😎

@Kubuxu
Copy link
Member

Kubuxu commented Nov 21, 2016

I don't really know how to expose dial errors nicely without exposing all others dial errors.

I would have to propagate some type of dial error through whole stack:

18:57:04.432 DEBUG     swarm2: dial end <nil> swarm_dial.go:204
18:57:04.432 DEBUG       core: failed to bootstrap with <peer.ID SoLV4B>: dial attempt failed: misdial to <peer.ID SoLV4B> through /ip4/104.236.76.40/tcp/4001 (got <peer.ID >): could not read full nonce bootstrap.go:179

Yeah, command for generating those keys will be nice UX wise.

@jbenet
Copy link
Member Author

jbenet commented Nov 21, 2016

(for the one in the private network) something clear, like:

18:57:04.432 WARN      swarm2: failed to connect with <peer.ID <id>>: secure handshake failed. (shared key mismatch?)

you dont have to thread it through, i think. you should be able to log from almost anywhere

@Kubuxu
Copy link
Member

Kubuxu commented Nov 21, 2016

Right, I can log it. 👍

@Kubuxu
Copy link
Member

Kubuxu commented Nov 21, 2016

I can try but it won't be easy.
I for sure can create nice banner so it is visible that you are in private network.

@salsa-dev
Copy link

salsa-dev commented Feb 22, 2018

I was asked to leave a feedback about usage of private key in production from #1633.
Not sure what exactly is of any interest to devs but here is my use case:

Infrastructure has Git server and IPFS server(s).
Project's Git repo includes a file .ipfs where I put paths and hashes of the project's binary files which are not kept in Git.

On production VMs IPFS is installed with private key /home/ipfs/.ipfs/swarm.key:

/key/swarm/psk/1.0.0/
/bin/
some_long_key

Automation software removes bootstrap list and adds a couple of the servers in Infrastructure and then pulls code out of Git server and binary files out of IPFS. So, more like git-lfs.

That helps to devide projects code from binary files and keep things distributed.
Thanks to IPFS!!!!

If anything particular is needed for statistics or perfomance you are welcome to ping me here.

@Kubuxu
Copy link
Member

Kubuxu commented Feb 23, 2018

@salsa-dev I am glad you find the feature useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants