Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache merkledag nodes in dagservice #2849

Open
whyrusleeping opened this issue Jun 13, 2016 · 2 comments
Open

cache merkledag nodes in dagservice #2849

whyrusleeping opened this issue Jun 13, 2016 · 2 comments
Labels
exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue status/deferred Conscious decision to pause or backlog

Comments

@whyrusleeping
Copy link
Member

Adding in a cache for recently used merkledag nodes will improve performance on workloads that rely on manipulating object graphs.

Ideally, the size of the cache should be configurable from the config file, and if set to default (or unset in the config) be reduced when IPFS_LOW_MEM is set.
@whyrusleeping whyrusleeping added help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up labels Jun 13, 2016
@whyrusleeping whyrusleeping mentioned this issue Jun 13, 2016
Closed
@kevina
Copy link
Contributor

kevina commented Jun 20, 2016

This seams easy enough. I will take a shot at implementing this.

@whyrusleeping whyrusleeping added this to the Ipfs 0.4.3 milestone Jun 21, 2016
@kevina kevina mentioned this issue Jun 22, 2016
Closed
@Kubuxu Kubuxu added the status/in-progress In progress label Jun 23, 2016
@Kubuxu Kubuxu removed this from the ipfs-0.4.3 milestone Jul 6, 2016
@Kubuxu Kubuxu added status/deferred Conscious decision to pause or backlog and removed status/in-progress In progress labels Sep 28, 2016
@Stebalien Stebalien added exp/wizard Extensive knowledge (implications, ramifications) required and removed exp/novice Someone with a little familiarity can pick up labels Oct 8, 2019
@Stebalien
Copy link
Member

This is non-trivial as IPLD nodes aren't always thread safe (yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue status/deferred Conscious decision to pause or backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Stebalien @whyrusleeping @kevina @Kubuxu