Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double "Transfer-Encoding" headers #2385

Closed
daviddias opened this issue Feb 21, 2016 · 3 comments
Closed

double "Transfer-Encoding" headers #2385

daviddias opened this issue Feb 21, 2016 · 3 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@daviddias
Copy link
Member

caught by @RichardLitt documentation efforts:

https://github.com/ipfs/http-api-spec/blob/master/apiary.apib#L2938-L2942

@daviddias daviddias added the kind/bug A bug in existing code (including security flaws) label Feb 21, 2016
@dignifiedquire
Copy link
Member

So I found out a bit more about this. According to the http spec these are equivalent:

HTTP/1.1 200 OK\r\n
Transfer-Encoding: chunked\r\n
Transfer-Encoding: chunked\r\n

should be the same as

HTTP/1.1 200 OK\r\n
Transfer-Encoding: chunked, chunked\r\n

So the question is, are we actually double chunking our responses, and if so why?

This is also making some problems for me as I'm trying to use rust http libraries which are not yet able to handle this:

@whyrusleeping
Copy link
Member

Okay, so we're sending the transfer encoding twice... which is wrong. but we arent doing double chunked encoding. I'll take a look

@Kubuxu
Copy link
Member

Kubuxu commented May 17, 2016

Resolved by #2465. If not please reopen.

@Kubuxu Kubuxu closed this as completed May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

4 participants