Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding hidden files directly should work without flag #2145

Closed
whyrusleeping opened this issue Jan 2, 2016 · 3 comments
Closed

adding hidden files directly should work without flag #2145

whyrusleeping opened this issue Jan 2, 2016 · 3 comments
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) topic/commands Topic commands

Comments

@whyrusleeping
Copy link
Member

ipfs add .vimrc should just figure things out and add the file. The hidden ignore stuff should only take effect on recursive directory enumeration
@daviddias daviddias added the topic/commands Topic commands label Jan 2, 2016
@hackergrrl hackergrrl mentioned this issue Jan 13, 2016
Closed
hackergrrl added a commit to hackergrrl/go-ipfs that referenced this issue Jan 14, 2016
@hackergrrl
Lets 'ipfs add' include top-level hidden files.
192218d 
Fixes ipfs/go-ipfs/ipfs#2145. The --hidden only affects recursive adding.

License: MIT
Signed-off-by: Stephen Whitmore <[email protected]>
hackergrrl added a commit to hackergrrl/go-ipfs that referenced this issue Jan 14, 2016
@hackergrrl
Lets 'ipfs add' include top-level hidden files.
15554b1 
Fixes ipfs/go-ipfs/ipfs#2145. The --hidden switch (still) only affects
recursive adding.

License: MIT
Signed-off-by: Stephen Whitmore <[email protected]>
@hackergrrl hackergrrl mentioned this issue Jan 14, 2016
Merged
hackergrrl added a commit to hackergrrl/go-ipfs that referenced this issue Jan 15, 2016
@hackergrrl
Lets 'ipfs add' add hidden files when explicit.
0828d1e 
Fixes ipfs/go-ipfs/ipfs#2145. The --hidden switch (still) only affects
recursive adding.

License: MIT
Signed-off-by: Stephen Whitmore <[email protected]>
@hackergrrl
Copy link
Contributor

@whyrusleeping: can you confirm & close? (Is that how you usually do things here? Reporter verifies?)

@jbenet
Copy link
Member

jbenet commented Jan 19, 2016

@noffle yeah sometimes. i support doing that often/most of the time.

@hackergrrl hackergrrl mentioned this issue Jan 19, 2016
Closed
@RichardLitt RichardLitt added exp/novice Someone with a little familiarity can pick up and removed difficulty: easy labels Feb 2, 2016
@Kubuxu Kubuxu added the kind/bug A bug in existing code (including security flaws) label May 24, 2016
@Kubuxu
Copy link
Member

Kubuxu commented May 24, 2016

This is working, somewhere in last 60 commits it got fixed.

@Kubuxu Kubuxu closed this as completed May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) topic/commands Topic commands
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jbenet @hackergrrl @RichardLitt @daviddias @whyrusleeping @Kubuxu