Keep getting error after update to 0.3.3

[Gozala]

Received interrupt signal, shutting down...
Publishing!
17:39:32.927 ERROR     ipnsfs: leveldb: closed system.go:83

[Gozala]

Ok I noticed following in my config:

"Datastore": {
    "Type": "leveldb",
    "Path": "/Users/gozala/.go-ipfs/datastore"
  },

And there is no .go-ipfs directory on my machine instead there is .ipfs which is probably why I get that error. Not sure if that was a migration that screw up a config or what but I think this is a reason I wind up with broken ipfs.

[Gozala]

Ok it looks like wrong path was not an issue, as fixing a config does not changed anything.

[whyrusleeping]

Hrm, this appears to be a leftover from a time when our datastores were actually configuruable [insert whyrusleeping's grumblings about the fsrepo here].

We should revert to respecting this.

[Gozala]

@whyrusleeping in fact I have completely removed .ipfs & inited it from scratch but I still seem to get same error. In fact very few things work after update to [email protected] could be that this issue somehow related to #1214

[whyrusleeping]

oh, the error log you are seeing isnt actually a problem, its just a reminder for us to fix the daemon shutdown code.

[jbenet]

@Gozala thanks for bringing this up. as @whyrusleeping mentions, this is a confluence of a few things. I think the main problem you're seeing is the resolver problem #1212 addressed -- which definitely would break many things. (Sorry about the confusion-- the tests and I both missed the bug when we merged it in yesterday.)

---

17:39:32.927 ERROR     ipnsfs: leveldb: closed system.go:83

@whyrusleeping maybe we should silence this error, because it's not an error users are concerned with (i.e. it's debugging mostly), and it just confuses people atm.

---

Ok it looks like wrong path was not an issue, as fixing a config does not changed anything.

Yeah, this brings up another cleanup bug: we should remove those keys from the config as they're not used anymore the way they used to be. (we should definitely remove Datastore.Path and maybe Datastore.Type too, as leveldb/flatfs mix is not optional at the moment.

Or maybe keep Datastore.Type until we figure out how we'll distinguish storage once the s3 datastore (and possible full s3 repo) come around. (cc @tv42)

---

@whyrusleeping we should either make

Publishing!

more useful to the user, or remove it. if keeping, maybe something like:

auto-publishing mounted /ipns/<name> to /ipfs/<path>

---

Summary:

• merged path/resolver: Fix recursive path resolution #1212 (should fix main problem)
• test whether path/resolver: Fix recursive path resolution #1212 merged fixes your error (@Gozala)
• remove Datastore.path from config, as it is no longer path-configurable that way. (probably worth adding to a next migration)
• perhaps remove Datastore.Type as that is not configurable either anymore (we should have removed support for that cleanly, or not at all...)
• make Publishing more informative or remove it. (@whyrusleeping ?)
• remove leveldb error?
• cleanup daemon shutdown

[jbenet]

thanks for bringing this up @Gozala ! sorry for confusing error cases atm. this managed to hit lots of misleading red herrings. :/

[Gozala]

@jbenet sure np, yeah no worries I think combination of this errors and webui not working just made it hard to guess what's going on ;)

[jbenet]

@Gozala was the error you were seeing fixed?

Update: ah, just saw: #1214 (comment) no worries.

[Gozala]

Jus tried version from master, still seem to not work for me (posted output of errors I the other thread)
#1214 (comment)

[daviddias]

IPNS and files (old ipnsfs or mfs) had a lot of improvements in the last months, specially in the close to be released 0.4.0 (check dev0.4.0 branch). @Gozala would you mind testing it again and see if the error persists?

[whyrusleeping]

I beleive this has since been resolved (or is no longer an issue). Feel free to open a new issue if there are still problems.