Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinning taking up lots of CPU on benchmarks #1192

Closed
whyrusleeping opened this issue May 3, 2015 · 3 comments
Closed

pinning taking up lots of CPU on benchmarks #1192

whyrusleeping opened this issue May 3, 2015 · 3 comments
Labels
kind/bug A bug in existing code (including security flaws) topic/perf Performance

Comments

@whyrusleeping
Copy link
Member

I was looking over the benchmarks for the dagmodifier since someone mentioned writing a large file into /ipns was slow, and i noticed that we are spending a lot of time right here: https://github.com/ipfs/go-ipfs/blob/master/pin/indirect.go#L46

We really shouldnt be marshaling keys to base58 for this...

@tv42 in your pinning stuff you were working on, you dont do any b58 marshaling, right?

@whyrusleeping whyrusleeping added kind/bug A bug in existing code (including security flaws) topic/perf Performance labels May 3, 2015
@tv42
Copy link
Contributor

tv42 commented May 3, 2015

@whyrusleeping I consider needing base58 outside of UI a design failure.

@whyrusleeping
Copy link
Member Author

@tv42 good.

@whyrusleeping
Copy link
Member Author

this is much better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) topic/perf Performance
Projects
None yet
Development

No branches or pull requests

3 participants