chore: downgrade peer-id to the same version used by libp2p #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
approved these changes
Sep 25, 2019
| @@ -183,7 +186,7 @@ const embedPublicKey = async (publicKey, entry) => { | |||
| */ | |||
| const extractPublicKey = (peerId, entry) => { | |||
| if (!entry || !peerId) { | |||
| const error = 'one or more of the provided parameters are not defined' | |||
| const error = new Error('one or more of the provided parameters are not defined') | |||
There was a problem hiding this comment.
Should we do the new Error only on throw?
Same applies on another case below
There was a problem hiding this comment.
There won't be a stack trace in the logs if we just log the message.
There was a problem hiding this comment.
I usually prefer to have clean logs and with the ERR CODE find and replicate the issue. But, I understand your point as well
There was a problem hiding this comment.
If there's only one place in the entire codebase a certain error code is emitted, and it's also only invoked from one place in the entire codebase I'd agree, but that's rarely the case so more verbose logs can only help.
This is to ensure you can dial other peers on the network, otherwise libp2p doesn't think peer-ids are peer-ids.
achingbrain
force-pushed
the
downgrade-peer-id
branch
from
ce98789
to
9cf3110
Compare
vasco-santos
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to upgrade
ipfsto the latestlibp2p, otherwise you end up with multiple versions ofpeer-idin the dependency tree and then libp2p thinks peer-ids are not peer-ids and can't dial anything.Depends on libp2p/js-libp2p-crypto#158