feat: add routing id key #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vasco-santos
force-pushed
the
feat/add-libp2p-id-key
branch
from
0b6b2fd
to
bcceb45
Compare
fsdiogo
reviewed
Sep 6, 2018
src/index.js
Outdated
| @@ -210,6 +210,7 @@ const getIdKeys = (pid) => { | |||
|
|
|||
| return { | |||
| pkKey: new Key(rawStdEncoding(Buffer.concat([pkBuffer, pid]))), | |||
| routingKey: new Key(`/ipns/${pid}`), // Added on https://github.com/ipfs/js-ipns/pull/6 (ipnsKey will be deprecated in a future release) | |||
There was a problem hiding this comment.
You should leave a comment here with the explanation as to why this addition.
Simply leave a link to your comment: https://github.com/ipfs/js-ipns/pull/6#issue-213631461
Other than that LGTM.
fsdiogo
approved these changes
Sep 6, 2018
vasco-santos
force-pushed
the
feat/add-libp2p-id-key
branch
from
bcceb45
to
a9372d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the first step of
ipns working locally, the records needed to be stored usingbase32(/ipns/{cid}), in order to guarantee interop withgo-ipfs.However, integrating the DHT with
ipfs, thedhtwill be responsible for thebase32operation, as it does for all records stored in it, which in this case would end up onbase32(base32(/ipns/{cid})).Accordingly, a new ID key was added (
routingKey), which should be used for the routing part ofIPNS. After this got released, theipnsKeywill not be needed anymore.