Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program run via exec and outputting to stderr assumes failure #234

Closed
victorb opened this issue Apr 29, 2018 · 2 comments
Closed

Program run via exec and outputting to stderr assumes failure #234

victorb opened this issue Apr 29, 2018 · 2 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@victorb
Copy link
Member

victorb commented Apr 29, 2018

Currently if you try to run a js-ipfs daemon via js-ipfsd-ctl with DEBUG set to *, ipfsd-ctl will not work correctly and assume that the js-ipfs daemon outputs errors, since the npm module debug outputs to stderr.

Rather than just seeing if there is data on stderr and fail if there is, we should save the data and output it if the exit status is not 0.

Line in question that makes the assumption:

command.stderr.on('data', listeners.error)

@victorb victorb added the kind/bug A bug in existing code (including security flaws) label Apr 29, 2018
@dryajov
Copy link
Member

dryajov commented Apr 29, 2018

Thanks @victorbjelkholm! This sounds reasonable and seems like it would fix our logging issues 👍

@daviddias daviddias added the status/ready Ready to be worked label May 30, 2018
@achingbrain
Copy link
Member

This should be fixed by #270

@ghost ghost removed the status/ready Ready to be worked label Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

5 participants