-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Switch from IPFS_REUSEPORT to LIBP2P_TCP_REUSEPORT #3955
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
@achingbrain any idea why this PR is failing, is it just flakiness/pre-existing failures or something new here? The |
Looks like a regression was caused by libp2p/js-libp2p-crypto#202 |
Actually on closer inspection this is caused by multiple versions of #3947 brings it all into line, though it needs releases of: |
This reverts commit c936ed5.
The `LIBP2P_TCP_REUSEPORT` env var has been around in go-libp2p for a few years and they're now dropping support for IPFS_REUSEPORT (libp2p/go-tcp-transport#104) Co-authored-by: achingbrain <[email protected]>
No description provided.