This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
[WIP] feat: add travis #1731
Closed
[WIP] feat: add travis #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
alanshaw
suggested changes
Nov 29, 2018
There was a problem hiding this comment.
Please can the package.lock change be submitted as a separate PR? It needs discussion and visibility to contributors.
We also need a PR to https://github.com/ipfs/community/blob/master/CONTRIBUTING_JS.md to propose it to the IPFS/IPLD/libp2p ecosystem.
.travis.yml
Outdated
| os: windows | ||
| name: "windows-node-10" | ||
| node_js: 10 | ||
| script: npm run test:node:http -- --bail |
There was a problem hiding this comment.
Needs browser, web worker and coverage steps!
hugomrdias
force-pushed
the
feat/add-travis
branch
from
0fdd4d5
to
a178907
Compare
daviddias
reviewed
Nov 29, 2018
hugomrdias
force-pushed
the
feat/add-travis
branch
from
129b156
to
d0ae0e8
Compare
|
Any update on this @hugomrdias? |
fix: add language node fix: add tests fix: add osx windows fix: naming fix: fix deps and add lock fix: fix deps fix: remove node 8 chore: update lock feat: add matrix and full tests feat: add gitattributes feat: fix git attributes path feat: test attributes 2 fix: trigger fix: fix line ending chore: remove allow failure chore: remove lock chore: ignore lock
hugomrdias
force-pushed
the
feat/add-travis
branch
from
458ced8
to
d821cf5
Compare
|
@hugomrdias can this be closed? Is it superseded by #1728? |
|
Yes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.