-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I tested this with ipfs/interface-datastore#24 in the context of ipfs-companion (#1615) and the fix works as expected, datastore key does not have a valid format
error is gone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but needs tests e.g. https://codecov.io/gh/ipfs/js-ipfs/src/master/src/core/ipns/publisher.js#L53...59
@alanshaw the I am not able to test this, unless I test the private functions directly or mock the |
da0df48
to
d222981
Compare
As
instance of
fails using different versions of a module, it was changed to useclass-is
.Needs:
Fixes #1615