This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Fix js-ipfs daemon config params #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Respect `--enable-experimental-pubsub` - Don't overload repo config with cli args (fixes ipfs#868) - Typo
That seems weird, what npm version? Think npm@5 and above is not working well with aegir, but npm@4 should work ok. Also, CI is failing, unsure of why... @diasdavid ideas? |
|
Edit: I broke the tests because I don't pass down Its npm version 5.2. |
- Add an extra parameter for `HttpAPI` for `cliArgs`
daviddias
approved these changes
Jul 19, 2017
| @@ -16,7 +16,7 @@ module.exports = { | |||
| default: false | |||
| }, | |||
| 'enable-pubsub-experiment': { | |||
| type: 'booleam', | |||
| type: 'boolean', | |||
dryajov
pushed a commit
that referenced
this pull request
Sep 1, 2017
* Fix js-ipfs daemon config params - Respect `--enable-experimental-pubsub` - Don't overload repo config with cli args (fixes #868) - Typo * Treat cli args and config overload as seperate - Add an extra parameter for `HttpAPI` for `cliArgs`
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
This was accidentally disabled and no tests existed to catch it. * [x] depends on ipfs-inactive/interface-js-ipfs-core#420 License: MIT Signed-off-by: Alan Shaw <[email protected]>
This was referenced Dec 13, 2021
This was referenced Jan 24, 2022
This was referenced Apr 28, 2023
This was referenced Apr 28, 2023
This was referenced Apr 28, 2023
This was referenced Jan 9, 2024
This was referenced Jan 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--enable-experimental-pubsubdaemonin CLI screws up config #868)I was unable to run tests, linting or anything. Did not work on node 8.1.2 or 6.11.1