webRTCStar discovery disabled by default

[pgte]

Against current master, to use webRTCStar discovery I had to set config.Discovery.webRTCStar.Enabled to true, even though I had config.Addresses.Swarm set to ['/libp2p-webrtc-star/dns4/star-signal.cloud.ipfs.team/wss'].

I think this wasn't necessary before.
If not a bug, perhaps it should be added to the instructions.

[daviddias]

@pgte could you check your repo to see if this flag is correctly set? https://github.com/ipfs/js-ipfs/blob/master/src/init-files/default-config-browser.json#L15

[daviddias]

I can see there is something, although discovery seems to be working:

I don't get to have two nodes in different Chrome windows (or even one using Firefox) to see each other. This could be related with the new SS set up libp2p/js-libp2p-webrtc-star#111. Do you see the same behaviour?

[daviddias]

Interesting, it might be my current network configuration (in a coffee shop). The ICE is not working between browser to browser but browser to wrtc works flawlessly.

[victorb]

@diasdavid

https://github.com/ipfs/js-ipfs/blob/master/src/init-files/default-config-browser.json#L15

Seems like in that file, the property Discovery is overwritten with {}

[daviddias]

You have to check what is the loaded config. Note, Discovery works, just to show added a console log on peers found:

[daviddias]

Still, no clue why 2 peers in the same machine are not finding each other. If we dial manually using connect, they dial successfully and exchange files.

[daviddias]

yeah, WebRTCStar Discovery is not being enabled :( hte whole Discovery disappears

[daviddias]

Ok, so I narrowed down the problem to this:

For some reason, the require('location of config') is yielding a config that has no keys on the Discovery property

[daviddias]

[victorb]

;)

[daviddias]

When I read "overwritten" I understood that somewhere in the code that was happening. thanks :)