This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ipfs get` on the cli writes files/folders to disk, also tarballs and gzipped tarballs. Also gzipped individual files. In the API it's very similar to `ipfs.ls`. Make it more like the cli so there's a clear reason to use one or the other. Also adds types to `interface-ipfs-core` to better catch broken types in `ipfs-core-types`.
achingbrain
changed the title
feat: make ipfs.get output tarballs
feat: make ipfs.get output tarballs and add types to interface-ipfs-core
Aug 4, 2021
achingbrain
changed the title
feat: make ipfs.get output tarballs and add types to interface-ipfs-core
feat: make ipfs.get output tarballs and add types to interface-ipfs-core tests
Aug 4, 2021
…tests-and-ipfs-get
achingbrain
changed the title
feat: make ipfs.get output tarballs and add types to interface-ipfs-core tests
feat: make ipfs.get output tarballs
Aug 9, 2021
achingbrain
added a commit
that referenced
this pull request
Aug 9, 2021
Not sure how the build for #3785 passed without this, but it did?
Merged
achingbrain
added a commit
that referenced
this pull request
Aug 9, 2021
Not sure how the build for #3785 passed without this, but it did?
This was referenced Nov 28, 2023
This was referenced Nov 28, 2023
This was referenced Nov 28, 2023
This was referenced Nov 28, 2023
This was referenced Nov 28, 2023
This was referenced Nov 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipfs get
on the cli writes files/folders to disk, also tarballs and gzipped tarballs. Also gzipped individual files.In the API it's very similar to
ipfs.ls
. Make it more like the cli so there's a clear reason to use one or the other.Also adds types to
interface-ipfs-core
and theipfs-core
tests to better catch broken types inipfs-core-types
.