Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: support keychain without pass #3212

Merged
merged 9 commits into from
Aug 10, 2020
Merged

fix: support keychain without pass #3212

merged 9 commits into from
Aug 10, 2020

Conversation

jacobheun
Copy link
Contributor

@jacobheun jacobheun commented Aug 5, 2020

  • add support for ed25519 and secp256k1 keys for the ipfs PeerId
  • add support for using ed25519 and secp256k1 keys with ipns
  • add support for keychain without a pass, this fixes several keychain commands
  • fix name publish, ttl should be optional but wasn't being allowed

Includes changes in #3208

Key gen and key listing now works:

$ jsipfs key gen --type=ed25519 my-ed-key
generated QmUPJZ3ghsnkRVgYjrMrSC8MbbZTzcezn6mH7vY9vTbrMY my-ed-key

$ jsipfs key list
QmUPJZ3ghsnkRVgYjrMrSC8MbbZTzcezn6mH7vY9vTbrMY my-ed-key
QmYPxJJb8Mpa6JjQj7hCTF4ajn2SE1HFLRoAnCbymTGzyC self

IPNS Publishing now works properly, including using other key types:

jsipfs name publish -k my-ed-key /ipfs/QmP7WDyEdkFu2nfj35SUEB7fk3iKCHpcrCVbGk1HXZU22a
Published to 12D3KooWGmSq6u3yZeXqeqSmQpJWKQGGdCxrZQAUZBzsbSM2kCE6: /ipfs/QmP7WDyEdkFu2nfj35SUEB7fk3iKCHpcrCVbGk1HXZU22a

I also fixed a couple of the example tests, they weren't waiting for IPFS to start before executing the tests, which could cause them to intermittently fail.

BREAKING CHANGE: remove support for key.export over the http api

@jacobheun jacobheun force-pushed the fix/keychain branch 2 times, most recently from 782235e to 7bc1098 Compare August 5, 2020 22:02
@jacobheun jacobheun marked this pull request as ready for review August 6, 2020 21:08
@achingbrain achingbrain merged commit 7e0e85c into master Aug 10, 2020
@achingbrain achingbrain deleted the fix/keychain branch August 10, 2020 12:31
SgtPooki referenced this pull request in ipfs/js-kubo-rpc-client Aug 18, 2022
- add support for ed25519 and secp256k1 keys for the ipfs PeerId
- add support for using ed25519 and secp256k1 keys with ipns
- add support for keychain without a pass, this fixes several keychain commands
- fix `name publish`, ttl should be optional but wasn't being allowed

Includes changes in ipfs/js-ipfs#3208

Key gen and key listing now works:
```sh
$ jsipfs key gen --type=ed25519 my-ed-key
generated QmUPJZ3ghsnkRVgYjrMrSC8MbbZTzcezn6mH7vY9vTbrMY my-ed-key

$ jsipfs key list
QmUPJZ3ghsnkRVgYjrMrSC8MbbZTzcezn6mH7vY9vTbrMY my-ed-key
QmYPxJJb8Mpa6JjQj7hCTF4ajn2SE1HFLRoAnCbymTGzyC self
```

IPNS Publishing now works properly, including using other key types:
```sh
jsipfs name publish -k my-ed-key /ipfs/QmP7WDyEdkFu2nfj35SUEB7fk3iKCHpcrCVbGk1HXZU22a
Published to 12D3KooWGmSq6u3yZeXqeqSmQpJWKQGGdCxrZQAUZBzsbSM2kCE6: /ipfs/QmP7WDyEdkFu2nfj35SUEB7fk3iKCHpcrCVbGk1HXZU22a
```

I also fixed a couple of the example tests, they weren't waiting for IPFS to start before executing the tests, which could cause them to intermittently fail.

BREAKING CHANGE: remove support for key.export over the http api
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants