Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: correct dht reference in ipns routing #2996

Merged
merged 2 commits into from
Apr 24, 2020
Merged

Conversation

kumavis
Copy link
Contributor

@kumavis kumavis commented Apr 22, 2020

interface was updated here libp2p/js-libp2p#480

@kumavis
Copy link
Contributor Author

kumavis commented Apr 22, 2020

I'm aware that this is intended to be changed to use the content-routing interface instead (#2921 (comment)), but wanted to fix this bug (pushing in an undefined datastore) first as a quick fix

@kumavis
Copy link
Contributor Author

kumavis commented Apr 23, 2020

seeing an error related to the dht, maybe theres a version mismatch to what you get in this repo (via lockfile) vs consuming this package elsewhere

ipfs:       AssertionError: expected undefined to deeply equal [Function: functionStub]
ipfs:       + expected - actual
ipfs:       -[undefined]
ipfs:       +[Function]

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we should go this way while we fill the gap on the issue / libp2p side.

@kumavis
Copy link
Contributor Author

kumavis commented Apr 23, 2020

not sure why codecov is failing

@kumavis
Copy link
Contributor Author

kumavis commented Apr 23, 2020

strange

ipfs:       AssertionError: expected 'QmckaNuhfHhZe1wtQC9yPWtZXmu2g5svFnvSenzVu9dANf' to equal 'Qme79tX2bViL26vNjPsF3DP1R9rMKMvnPYJiKTTKPrXJjq'
ipfs:       + expected - actual
ipfs:       -QmckaNuhfHhZe1wtQC9yPWtZXmu2g5svFnvSenzVu9dANf
ipfs:       +Qme79tX2bViL26vNjPsF3DP1R9rMKMvnPYJiKTTKPrXJjq
ipfs:       
ipfs:       at Context.it (/home/travis/build/ipfs/js-ipfs/packages/interface-ipfs-core/src/add.js:5:437)
ipfs:       at process._tickCallback (internal/process/next_tick.js:68:7)

@achingbrain
Copy link
Member

Looks good for the most part, not sure about the CI failure, it seems unrelated.

Is there a test that could have picked this up?

@kumavis
Copy link
Contributor Author

kumavis commented Apr 24, 2020

test failure also seems to fail on node v10 and not on v12

@kumavis

This comment has been minimized.

@kumavis
Copy link
Contributor Author

kumavis commented Apr 24, 2020

@achingbrain @vasco-santos test failures same as on master #3000

travis jobs:
this pr https://travis-ci.com/github/ipfs/js-ipfs/builds/161639120
master with run-since removed https://travis-ci.com/github/ipfs/js-ipfs/builds/161773080

@achingbrain
Copy link
Member

achingbrain commented Apr 24, 2020

The should add a BIG buffer test is failing on Node 10 due to a regression in ipld-dag-pb, the fix is here: ipld/js-ipld-dag-pb#179

@achingbrain achingbrain merged commit d2579c0 into master Apr 24, 2020
@achingbrain achingbrain deleted the ipns-routing-dht-fix branch April 24, 2020 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants