-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: correct dht reference in ipns routing #2996
Conversation
interface was updated here libp2p/js-libp2p#480
I'm aware that this is intended to be changed to use the content-routing interface instead (#2921 (comment)), but wanted to fix this bug (pushing in an undefined datastore) first as a quick fix |
seeing an error related to the dht, maybe theres a version mismatch to what you get in this repo (via lockfile) vs consuming this package elsewhere
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we should go this way while we fill the gap on the issue / libp2p side.
not sure why codecov is failing |
strange
|
Looks good for the most part, not sure about the CI failure, it seems unrelated. Is there a test that could have picked this up? |
test failure also seems to fail on node v10 and not on v12 |
This comment has been minimized.
This comment has been minimized.
@achingbrain @vasco-santos test failures same as on master #3000 travis jobs: |
The |
interface was updated here libp2p/js-libp2p#480