-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore: update importer to only output unixfs things #2747
chore: update importer to only output unixfs things #2747
Conversation
7f03fac
to
e93db3e
Compare
Refs #2696 |
Just double checking: I think this is a good idea. It will cause an interop issue with go-ipfs because CIDs will be different for the same data (when Will you also check there is an interop test for this (albeit skipped for now)? 🙏 |
e93db3e
to
b318872
Compare
BREAKING CHANGE: Files that fit into one block imported with either `--cid-version=1` or `--raw-leaves=true` previously returned a CID that resolved to a raw node (e.g. a buffer). Returned CIDs now resolve to a `dag-pb` node that contains a UnixFS entry. This is to allow setting metadata on small files with CIDv1.
2f0c205
to
f79a7b8
Compare
This change is in line with @Stebalien's comment here: ipfs-inactive/js-ipfs-unixfs-importer#44 (comment) so I believe there is consensus 😉
Right here: ipfs/kubo#6940
Here: ipfs/interop#105 Kind of an aside but I think we should move most of those interop tests to the interface suite - I think the interop tests should be focused on networking type stuff between go, js, rust etc. E.g. bitswap, the dht, pubsub, etc. |
…s#2747) BREAKING CHANGE: Files that fit into one block imported with either `--cid-version=1` or `--raw-leaves=true` previously returned a CID that resolved to a raw node (e.g. a buffer). Returned CIDs now resolve to a `dag-pb` node that contains a UnixFS entry. This is to allow setting metadata on small files with CIDv1.
BREAKING CHANGE: Files that fit into one block imported with either `--cid-version=1` or `--raw-leaves=true` previously returned a CID that resolved to a raw node (e.g. a buffer). Returned CIDs now resolve to a `dag-pb` node that contains a UnixFS entry. This is to allow setting metadata on small files with CIDv1.
BREAKING CHANGE:
If you specify
raw-nodes
to be true orcid-version
to be1
and your data fits in one chunk, you would previously get aCID
that resolves to anipld-raw
node.Now you will get a
CID
that resolves to adag-pb
node, so the output of every import will be aunixfs
object.