Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat: add human flag to repo stat cli command #2630

Merged
merged 1 commit into from
Nov 27, 2019

Conversation

PedroMiguelSS
Copy link
Contributor

@PedroMiguelSS PedroMiguelSS commented Nov 25, 2019

This PR adds --human flag to repo stat command.

Usage:

> jsipfs repo stat --human

Output:

NumObjects: 16
RepoSize: 30.1 KB
StorageMax: 9.01 PB
RepoPath: /var/folders/l1/(...)
Version: 7

This PR supersedes #2592.
Reason: ipfs/js-ipfs-repo#213 (comment).

⚠️This PR needs the following PR merged and released before this one can be:

Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

⚠️This PR needs the following PR merged and released before this one can be:

It doesn't actually depend on it though...right? I think we should get this merged and we can get the repo update later.

@PedroMiguelSS
Copy link
Contributor Author

Yap, it does not depend directly on it. I was just making sure we got js-ipfs-repo updated when this one was merged. But we can do as you say: merge it and update the dependency later.

@alanshaw alanshaw merged commit 39bc5b4 into master Nov 27, 2019
@alanshaw alanshaw deleted the feat/add-repo-stat-cli-human-option branch November 27, 2019 06:37
alanshaw pushed a commit that referenced this pull request Nov 27, 2019
Change accidentially merged with #2630
@alanshaw alanshaw mentioned this pull request Dec 9, 2019
57 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants