Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat: add --enable-preload to enable/disable preloading for daemons #1909

Merged
merged 1 commit into from
Mar 6, 2019
Merged

feat: add --enable-preload to enable/disable preloading for daemons #1909

merged 1 commit into from
Mar 6, 2019

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Mar 6, 2019

resolves #1529

@ghost ghost assigned alanshaw Mar 6, 2019
@ghost ghost added the status/in-progress In progress label Mar 6, 2019
vasco-santos
vasco-santos approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jacobheun
jacobheun approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I verified the flag shows up in help and that setting --enable-preload=false disables preloading.

@alanshaw alanshaw mentioned this pull request Mar 6, 2019
Closed
50 tasks
@alanshaw alanshaw merged commit 9470900 into master Mar 6, 2019
@ghost ghost removed the status/in-progress In progress label Mar 6, 2019
@alanshaw alanshaw deleted the feat/daemon-disable-preload branch March 6, 2019 11:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vasco-santos vasco-santos vasco-santos approved these changes

@jacobheun jacobheun jacobheun approved these changes

Assignees

@alanshaw alanshaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't disable preload for CLI daemon
3 participants
@alanshaw @jacobheun @vasco-santos