This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
chore: rename local option to offline #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
35 tasks
vasco-santos
force-pushed
the
chore/rename-local-option-to-offline
branch
from
6470969
to
74fac0c
Compare
|
Needs a "BREAKING CHANGE" in commit message please 🙏 |
BREAKING CHANGE: local option renamed to offline.
vasco-santos
force-pushed
the
chore/rename-local-option-to-offline
branch
from
74fac0c
to
739217a
Compare
|
This PR addresses point 1 in #1778 but does not resolve point 2. I've updated the PR description so that the issue is not closed when this is merged. |
hugomrdias
pushed a commit
to ipfs/js-ipfsd-ctl
that referenced
this pull request
Jan 30, 2019
In the context of ipfs/js-ipfs#1778 and ipfs/js-ipfs#1850 , this is now needed for the tests. BREAKING CHANGE: `--local` option has been renamed to `--offline`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #1778