This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: report correct size for raw dag nodes #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you specify `cidVersion: 0`, for go compatibility you will have raw leaf nodes. If your data fits in one dag node, the root node will be a raw node for the same reason, and `ipfs.object.get` will return a buffer. This PR inspects the returned node to see if it's a buffer, if it is, use the `length` property, otherwise use the DAGNode `size` property. Fixes #1585
ghost
assigned
achingbrain
commented
Sep 25, 2018
| expect(err).to.not.exist() | ||
| expect(files.length).to.equal(1) | ||
| expect(files[0].hash).to.equal('zdj7WcDSFNSsZkdkbpSDGeLsBtHbYKyvPQsaw6PpeeYdGqoAx') | ||
| expect(files[0].size).to.equal(11) |
There was a problem hiding this comment.
N.b. this is bigger than the input buffer due to the protobuf overhead. The other test uses raw nodes, so the data hasn't been wrapped in a protobuf.
alanshaw
approved these changes
Sep 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you specify
cidVersion: 0, for go compatibility you will have raw leaf nodes. If your data fits in one dag node, the root node will be a raw node for the same reason, andipfs.object.getwill return a buffer.This PR inspects the returned node to see if it's a buffer, if it is, use the
lengthproperty, otherwise use the DAGNodesizeproperty.Fixes #1585